[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: patch #8947: Don't try to execute a data file
From: |
Rob Savoye |
Subject: |
Re: patch #8947: Don't try to execute a data file |
Date: |
Tue, 22 Mar 2016 07:22:00 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 |
On 03/22/2016 01:15 AM, Ben Elliston wrote:
> + # Don't try to execute a data file, which is used by some tests
> + # to compare output.
> + if {[regexp "^\.txt$" $prog]} {
> + return ""
> + }
>
> Wouldn't it be better to not call unix_load with such an argument?
Unix_load is used to download a data file to the target, and the
output of the executable is compared. This is used by some of the GCC tests.
> Also, the patch contains a proc definition called make_absolute. It's
> redundant -- Tcl offers `file normalize'.
I can drop that from the patch, I didn't write it.
- rob -