Re: [Denemo-devel] Fedora and BinReloc

[Roy Rankin]

A quick look indicates that if ENABLE_BINRELOC is not defined gbr_init() 
just sets this error message and returns. As I do not like meaningless 
error messages, I have added the following patch  to the Fedora build.

Regards,
Roy Rankin

diff --git a/src/utils.c b/src/utils.c
index b0751ed..49b5cea 100644
--- a/src/utils.c
+++ b/src/utils.c
@@ -509,6 +509,7 @@ void
 initdir ()
 {
 #ifndef G_OS_WIN32
+#ifdef ENABLE_BINRELOC
   GError *error=NULL;
   if(!gbr_init (&error))
     {
@@ -521,6 +522,7 @@ initdir ()
       g_error_free (error);
       g_print ("----------------\n");
     }
+#endif /* ENABLE_BINRELOC */
 #endif /* not G_OS_WIN32 */
 }


Richard Shann wrote:
> I always get this message on startup of Denemo, I don't know what it
> means.
> Richard
>
> On Wed, 2008-09-03 at 19:19 +1000, Roy Rankin wrote:
> > I have been jumping through hoops and I am now the package maintainer 
> > for Denemo in Fedora. I am expecting Denemo-0.7.9 to be in Fedora 10 
> > which is coming out shortly.
> >
> > However, I have just discovered an issue. The build of Denemo in Fedora 
> > strips the binary which, as I understand, cause BinReloc to fail. Here 
> > are the messages I get.
> >
> > BinReloc failed to initialize:
> > Domain: 1 (GBinReloc)
> > Code: 4
> > Message: Binary relocation support is disabled.
> > ----------------
> >
> >
> > Why is BinReloc required? What happens if I just disable it so I do not 
> > get this message?
> >
> > Fedora 10 is going beta this weekend (Sept 7) and I would like to 
> > resolve this before then.
> >
> > Regards,
> > Roy Rankin
> >
> >
> > _______________________________________________
> > Denemo-devel mailing list
> > address@hidden
> > http://lists.gnu.org/mailman/listinfo/denemo-devel
>
>
>
> _______________________________________________
> Denemo-devel mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/denemo-devel