[Denemo-devel] scheme_change_chord_notes

[Jeremiah Benham]

I created a new function that I pushed to git. It is called 
scheme_change_chord_notes. It is in view.c. 

The cursor must be over a chord (more than one note at once). It allows you to 
respell the notes in the chord. It takes a list as an argument. 

Test with:
   (define list '("a" "b" "c"))
   (d-ChangeChordNotes list)
   (d-RefreshDisplay)

The octave does not seem correct though. I will have to adjust this. 

I created this to help facilitate the transposition script to change chord 
tones. Should I document this function in the manual in git or should it go 
onto the wiki?

I was about to create anouther function similar to GetNotes. Before I did that 
I was going to ask if there was an easy way to seperate the out put of GetNotes 
into a list. If not I would write a similar function returning a list instead 
of a string. This is also needed for the transpose script. It needs to be able 
to read the note names in a chord then it has to determine what the destination 
note will be and send this to the d-ChangeChordNotes procedure. Would it be 
called a function or a procedure if its written in c but interfaced via guile?

Jeremiah

ps. While looking through the code I came across two functions that do the 
exact same thing. They are removetone(...) and tonechange(...). tonechange 
seems to be more widely in the code. removetone is only used by commandfuncs.c. 
To make things worse removetone is in chordops.c where you would expect this 
function to be. tonechange(...) is used commandfuncs.c were you would not 
expect it to be. I propose we remove removetone(...) and move tonechange(...) 
to chordops.c. The code in commandfuncs.c calling removetone(...) should be be 
updated to use  tonechange(...). I just thought I would give a heads up to make 
sure that this was not done on purpose.