[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Denemo-devel] SHOWSTOPPER bug Re: Release 1.1.6
|
From: |
Richard Shann |
|
Subject: |
[Denemo-devel] SHOWSTOPPER bug Re: Release 1.1.6 |
|
Date: |
Fri, 20 Jun 2014 10:03:16 +0100 |
I've just realized that you can crash Denemo-1.1.6 simply by hitting
Delete Verse in the lyrics menu (if you have no verses) and that this is
a regression from 1.1.4
so I think this has to be a showstopper bug, people could lose their
work on an idle click.
I'll apply the fix to stable-1.1.6 later today (it is already in
master).
Richard
On Fri, 2014-06-13 at 15:25 +0100, Richard Shann wrote:
> I have updated the stable-1.1.6 branch with the translations, can you
> generate tarball and binaries for final sanity checking before we upload
> them to gnu.org?
>
> Richard
>
>
> On Thu, 2014-06-05 at 09:44 +0100, Richard Shann wrote:
> > This is working fine - I've tested creating, midi input, printing ...
> > all working out of the box.
> > We are just waiting for translations ... we could a allow a week for
> > that I guess.
> >
> > Richard
> >
> >
> > On Wed, 2014-06-04 at 09:50 -0500, Jeremiah Benham wrote:
> > > Ok. The mingw build is ready for testing.
> > >
> > > Jeremiah
> > >
> > > On Jun 3, 2014 2:39 AM, "Richard Shann" <address@hidden>
> > > wrote:
> > > On Mon, 2014-06-02 at 13:10 -0500, Jeremiah Benham wrote:
> > > > Now I am getting this:
> > > > view.o:view.c:(.text+0xf676): undefined reference to
> > > `_gtk_paned_new'
> > > > collect2: ld returned 1 exit status
> > > > make[2]: *** [denemo.exe] Error 1
> > > >
> > > >
> > > > It seems as if gtk_paned_new is gtk3 only.
> > >
> > > ok - I've fixed that, and checked there are no more
> > > gtk_paned_new calls,
> > > should be good now.
> > > Richard
> > >
> > > >
> > > >
> > > > Jeremiah
> > > >
> > > >
> > > >
> > > > On Mon, Jun 2, 2014 at 2:07 AM, Richard Shann
> > > > <address@hidden> wrote:
> > > > On Mon, 2014-06-02 at 00:18 -0500, Jeremiah Benham
> > > wrote:
> > > > > I googled it but am not sure how to fix it right
> > > away. I am
> > > > very busy
> > > > > at the moment. If you could pass along a patch
> > > that would be
> > > > > appreciated.
> > > >
> > > > I have updated stable-1.1.6 so that lyric.c should
> > > now compile
> > > > for GTK2
> > > > (I have not actually built on GTK2, but the new code
> > > does
> > > > compile).
> > > > Let me know when there are binaries to test.
> > > > Richard
> > > >
> > > >
> > > > > I installed the gtk3 binary windows devel files
> > > and
> > > > compiled against
> > > > > them in gub. It did compile denemo, evince,
> > > gtksourceview. I
> > > > had to
> > > > > copy the dll's from gub to the windows build bin
> > > directory
> > > > manually.
> > > > >
> > > >
> > >
> > > http://denemo.org/~jjbenham/gub/target/mingw/root/usr/bin/dlls2.zip
> > > > >
> > > > > After installation, unziping the dll's, and a
> > > reboot, I got
> > > > denemo to
> > > > > launch in Winxp. Unfortunately when it launched a
> > > window
> > > > pops up
> > > > > saying that the application is causing itself to
> > > terminate
> > > > (or
> > > > > something like that). If I moved this window, I
> > > could enter
> > > > notes into
> > > > > denemo for about a minute until it crashed. I am
> > > not sure
> > > > how to debug
> > > > > this, I might have better luck starting again with
> > > mxe.
> > > > >
> > > > >
> > > > > Jeremiah
> > > > >
> > > > >
> > > > >
> > > > > On Sun, Jun 1, 2014 at 10:57 AM, Richard Shann
> > > > > <address@hidden> wrote:
> > > > > On Wed, 2014-05-28 at 09:23 -0500,
> > > Jeremiah Benham
> > > > wrote:
> > > > > > Now failing here:
> > > > >
> > > >
> > > >
> > > /home/jjbenham/public_html/gub/target/mingw/src/denemo-1.1.6/src/command/lyric.c:331:
> > > error: 'GTK_STATE_FLAG_FOCUSED' undeclared (first use in this function)
> > > > > >
> > > > > > Surely I can look that up but I will
> > > need to do
> > > > that later.
> > > > > I guess
> > > > > > its just a reminder that we need to have
> > > a
> > > > solution for
> > > > > mingw gtk3
> > > > > > builds. I can compile an early version
> > > of gtk3
> > > > with gub for
> > > > > mingw but
> > > > > > we had problems with evince not loading
> > > the
> > > > backend. I did
> > > > > build a
> > > > > > version of gtk3 in mxe but I need to
> > > write a test
> > > > for it. I
> > > > > am not
> > > > > > sure if it works or not.
> > > > >
> > > > >
> > > > > Well it certainly would be good not to
> > > have to
> > > > continue
> > > > > supporting gtk2,
> > > > > but it would be a shame to hold up
> > > releasing new
> > > > features
> > > > > because of the
> > > > > difficulties in building for windows.
> > > > > Shall I put in some conditional code for
> > > these
> > > > gtk3-isms, they
> > > > > must be
> > > > > very, very, few (in fact, I expect you
> > > have found
> > > > both of them
> > > > > already)?
> > > > >
> > > > > Richard
> > > > >
> > > > >
> > > > > >
> > > > > >
> > > > > > Jeremiah
> > > > > >
> > > > > >
> > > > > >
> > > > > > On Mon, May 26, 2014 at 11:36 AM,
> > > Richard Shann
> > > > > > <address@hidden> wrote:
> > > > > >
> > > > > > Hmm, I guess you still have GTK2
> > > on mingw?
> > > > I see
> > > > > that the
> > > > > > typedef for GdkRGBA is quite
> > > simple:
> > > > > >
> > > > > > typedef struct {
> > > > > > gdouble red;
> > > > > > gdouble green;
> > > > > > gdouble blue;
> > > > > > gdouble alpha;
> > > > > > } GdkRGBA;
> > > > > >
> > > > > > perhaps it might be enough to
> > > include this
> > > > for the
> > > > > windows
> > > > > > build, we could have a
> > > > > >
> > > > > > #if GTK_MAJOR_VERSION==2
> > > > > > typedef struct {
> > > > > > gdouble red;
> > > > > > gdouble green;
> > > > > > gdouble blue;
> > > > > > gdouble alpha;
> > > > > > } GdkRGBA;
> > > > > > #endif
> > > > > >
> > > > > > I've tested this syntax, though
> > > there may
> > > > be further
> > > > > GTK3-isms
> > > > > > to be
> > > > > > found, if you can build on
> > > GNU/Linux
> > > > against GTK2
> > > > > that may
> > > > > > save more
> > > > > > iterations.
> > > > > >
> > > > > > Richard
> > > > > >
> > > > > >
> > > > > > On Mon, 2014-05-26 at 11:10
> > > -0500,
> > > > Jeremiah Benham
> > > > > wrote:
> > > > > > > I am getting these errors when
> > > compiling
> > > > for
> > > > > mingw:
> > > > > >
> > > > >
> > > >
> > > >
> > > /home/jjbenham/public_html/gub/target/mingw/src/denemo-1.1.6/src/command/lyric.c:
> > > In function 'add_verse_to_staff':
> > > > > >
> > > > >
> > > >
> > > >
> > > /home/jjbenham/public_html/gub/target/mingw/src/denemo-1.1.6/src/command/lyric.c:320:
> > > error: 'GdkRGBA' undeclared (first use in this function)
> > > > > >
> > > > >
> > > >
> > > >
> > > /home/jjbenham/public_html/gub/target/mingw/src/denemo-1.1.6/src/command/lyric.c:320:
> > > error: (Each undeclared identifier is reported only once
> > > > > >
> > > > >
> > > >
> > > >
> > > /home/jjbenham/public_html/gub/target/mingw/src/denemo-1.1.6/src/command/lyric.c:320:
> > > error: for each function it appears in.)
> > > > > >
> > > > >
> > > >
> > > >
> > > /home/jjbenham/public_html/gub/target/mingw/src/denemo-1.1.6/src/command/lyric.c:320:
> > > error: expected ';' before 'grayed'
> > > > > >
> > > > >
> > > >
> > > >
> > > /home/jjbenham/public_html/gub/target/mingw/src/denemo-1.1.6/src/command/lyric.c:321:
> > > error: expected ';' before 'white'
> > > > > >
> > > > >
> > > >
> > > >
> > > /home/jjbenham/public_html/gub/target/mingw/src/denemo-1.1.6/src/command/lyric.c:322:
> > > error: 'GTK_STATE_FLAG_FOCUSED' undeclared (first use in this function)
> > > > > >
> > > > >
> > > >
> > > >
> > > /home/jjbenham/public_html/gub/target/mingw/src/denemo-1.1.6/src/command/lyric.c:322:
> > > error: 'white' undeclared (first use in this function)
> > > > > >
> > > > >
> > > >
> > > >
> > > /home/jjbenham/public_html/gub/target/mingw/src/denemo-1.1.6/src/command/lyric.c:323:
> > > error: 'GTK_STATE_FLAG_NORMAL' undeclared (first use in this function)
> > > > > >
> > > > >
> > > >
> > > >
> > > /home/jjbenham/public_html/gub/target/mingw/src/denemo-1.1.6/src/command/lyric.c:323:
> > > error: 'grayed' undeclared (first use in this function)
> > > > > >
> > > > >
> > > >
> > > >
> > > /home/jjbenham/public_html/gub/target/mingw/src/denemo-1.1.6/src/command/lyric.c:
> > > In function 'add_verse':
> > > > > >
> > > > >
> > > >
> > > >
> > > /home/jjbenham/public_html/gub/target/mingw/src/denemo-1.1.6/src/command/lyric.c:338:
> > > warning: passing argument 1 of 'gtk_widget_show' from incompatible
> > > pointer type
> > > > > >
> > > > >
> > > >
> > > >
> > > /home/jjbenham/public_html/gub/target/mingw/src/denemo-1.1.6/src/command/lyric.c:
> > > In function 'delete_verse':
> > > > > >
> > > > >
> > > >
> > > >
> > > /home/jjbenham/public_html/gub/target/mingw/src/denemo-1.1.6/src/command/lyric.c:356:
> > > warning: passing argument 1 of 'gtk_widget_get_parent' from incompatible
> > > pointer type
> > > > > >
> > > > >
> > > >
> > > >
> > > /home/jjbenham/public_html/gub/target/mingw/src/denemo-1.1.6/src/command/lyric.c:
> > > In function 'reset_lyrics':
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > > > On Mon, May 26, 2014 at 7:25
> > > AM,
> > > > Jeremiah Benham
> > > > > > > <address@hidden>
> > > wrote:
> > > > > > > ok. I'm starting to
> > > build the
> > > > binaries
> > > > > now.
> > > > > > >
> > > > > > > Jeremiah
> > > > > > >
> > > > > > > On May 26, 2014 3:40
> > > AM,
> > > > "Richard Shann"
> > > > > > >
> > > <address@hidden> wrote:
> > > > > > > I see the
> > > stable-1.1.6
> > > > branch now,
> > > > > I have
> > > > > > checked it
> > > > > > > out and
> > > (thanks to
> > > > > > > Andreas
> > > Schneider)
> > > > managed to get
> > > > > make dist
> > > > > > to work.
> > > > > > > So I have
> > > uploaded
> > > > > > > the tarball
> > > generated by
> > > > this to
> > > > > > >
> > > > > > >
> > > > > >
> > > > http://www.denemo.org/~rshann/denemo-1.1.6.tar.gz
> > > > > > >
> > > > > > > as the
> > > candidate 1.1.6
> > > > source code
> > > > > release.
> > > > > > I'll send
> > > > > > > this to
> > > > > > >
> > > translationproject.org,
> > > > meanwhile
> > > > > if you can
> > > > > > generate
> > > > > > > binaries for
> > > > > > > testing I will
> > > test
> > > > them.
> > > > > > >
> > > > > > > Richard
> > > > > > >
> > > > > > >
> > > > > > > On Sun,
> > > 2014-05-25 at
> > > > 21:55 +0100,
> > > > > Richard
> > > > > > Shann
> > > > > > > wrote:
> > > > > > > > On Sun,
> > > 2014-05-25 at
> > > > 22:20
> > > > > +0200, Éloi
> > > > > > Rivard
> > > > > > > wrote:
> > > > > > > > > Yes it
> > > does appear.
> > > > > > > >
> > > > > > > > In that
> > > case,
> > > > Jeremiah, do you
> > > > > have time
> > > > > > to create a
> > > > > > > branch for
> > > 1.1.6
> > > > > > > > and a trial
> > > tarball?
> > > > > > > >
> > > > > > > > Richard
> > > > > > > >
> > > > > > > >
> > > > > > > >
> > > > > > > >
> > > > > >
> > > > _______________________________________________
> > > > > > > > Denemo-devel
> > > mailing
> > > > list
> > > > > > > >
> > > address@hidden
> > > > > > > >
> > > > > >
> > > > https://lists.gnu.org/mailman/listinfo/denemo-devel
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > >
> > > > > >
> > > > > >
> > > > > >
> > > > > >
> > > > >
> > > > >
> > > > >
> > > > >
> > > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > >
> > >
> >
> >
> >
> > _______________________________________________
> > Denemo-devel mailing list
> > address@hidden
> > https://lists.gnu.org/mailman/listinfo/denemo-devel
>
>
>
> _______________________________________________
> Denemo-devel mailing list
> address@hidden
> https://lists.gnu.org/mailman/listinfo/denemo-devel
- Re: [Denemo-devel] Release 1.1.6, Richard Shann, 2014/06/01
- Re: [Denemo-devel] Release 1.1.6, Jeremiah Benham, 2014/06/02
- Re: [Denemo-devel] Release 1.1.6, Richard Shann, 2014/06/02
- Re: [Denemo-devel] Release 1.1.6, Jeremiah Benham, 2014/06/02
- Re: [Denemo-devel] Release 1.1.6, Richard Shann, 2014/06/03
- Re: [Denemo-devel] Release 1.1.6, Jeremiah Benham, 2014/06/04
- Re: [Denemo-devel] Release 1.1.6, Richard Shann, 2014/06/05
- Re: [Denemo-devel] Release 1.1.6, Richard Shann, 2014/06/13
- Re: [Denemo-devel] Release 1.1.6, Jeremiah Benham, 2014/06/14
- Re: [Denemo-devel] Release 1.1.6, Richard Shann, 2014/06/28
- [Denemo-devel] SHOWSTOPPER bug Re: Release 1.1.6,
Richard Shann <=
- Re: [Denemo-devel] SHOWSTOPPER bug Re: Release 1.1.6, Richard Shann, 2014/06/20
- Re: [Denemo-devel] SHOWSTOPPER bug Re: Release 1.1.6, Richard Shann, 2014/06/20
- Re: [Denemo-devel] SHOWSTOPPER bug Re: Release 1.1.6, Jeremiah Benham, 2014/06/20
- Re: [Denemo-devel] SHOWSTOPPER bug Re: Release 1.1.6, Richard Shann, 2014/06/21