Re: diffutils-3.7.41-7475 exercises undefined behaviour

[Bruno Haible]

Hi Jim,

> Thanks again. Even though I never reproduced the issue, I've pushed
> the following, which should resolve it:
> 
> https://git.sv.gnu.org/cgit/diffutils.git/commit/?id=v3.7-42-g1aa7ccf

No, the patch does not fully resolve the issue. I still get

  Conditional jump or move depends on uninitialised value(s)
     at 0x402256: block_compare (cmp.c:622)
     by 0x402256: cmp (cmp.c:465)
     by 0x402256: main (cmp.c:361)

The reason is that valgrind is silent when you copy uninitialized values
to a different memory locations, and complains only when these uninitialized
values effectively have an effect. [1]

Here, the original uninitialized values are buf1[read0] and buf0[read1].

The attached patch fixes it (and does not introduce regressions in
"make check" without valgrind).

Bruno

[1] https://valgrind.org/docs/manual/mc-manual.html#mc-manual.uninitvals

0001-cmp-avoid-reading-uninitialized-memory.patch
Description: Text Data