Re: the gnustep wreckage. Part 1: windowmaker and user apps

[Alexander Malmberg]

Riccardo wrote:
[snip]
> 3. strange refresh problems (may be related to focus though). When 
> gnustep goes in the "focus trouble" mode (which is not _always_ but once 
> it is in it doesn't recover if not with restarting X). I ope the file 
> panel to open a file and just moving the mouse cursor over it makes the 
> window title refresh as wild (with the same name). While it doesn't 
> affect functionality it may be an indicator that something is wrong.

This sounds like an issue I've had a fix for locally for a while. Could 
you see if the attached patch fixes it? (It isn't entirely complete yet, 
but the missing part should only hurt in that focus may not 
automatically go to the right window in certain obscure cases.)

- Alexander Malmberg

Index: Source/NSApplication.m
===================================================================
RCS file: /cvsroot/gnustep/gnustep/core/gui/Source/NSApplication.m,v
retrieving revision 1.267
diff -u -r1.267 NSApplication.m
--- Source/NSApplication.m      10 Nov 2004 17:12:57 -0000      1.267
+++ Source/NSApplication.m      22 Nov 2004 00:09:31 -0000
@@ -1374,6 +1376,25 @@
 
   IF_NO_GC(pool = [arpClass new]);
 
+#if 0
+       /*
+       This is fairly broken, and causes excessive flickering in some cases.
+       Forcing the session window to be key, main, and ordered to the front
+       seems wrong:
+
+       1. -orderFrontRegardless will order it in front of other apps. The
+       user should be able to use other apps while in a modal session for
+       this app, and stray events shouldn't cause windows to order around.
+
+       2. Some windows work even in modal sessions. These might be ordered
+       on top of the session window, or become key or main, and we shouldn't
+       block this here.
+
+       3. -beginModalSessionForWindow: will already have ordered the window
+       in and made it key/main.
+
+       - Alexander Malmberg, 2003-11-18
+       */
   [theSession->window orderFrontRegardless];
   if ([theSession->window canBecomeKeyWindow] == YES)
     {
@@ -1383,6 +1404,7 @@
     {
       [theSession->window makeMainWindow];
     }
+#endif
 
   RELEASE (pool);