Re: [dmidecode] [PATCH v2 1/1] dmioem: Decode HPE OEM Record 238

[Jean Delvare]

On Tue, 31 May 2022 07:53:44 -0600, Jerry Hoemann wrote:
> On Tue, May 31, 2022 at 09:34:22AM +0200, Jean Delvare wrote:
> > This field is documented as WORD size, so 16 bits. Here you only pass
> > the first byte and ignore the second (at offset 0xA). Result should be
> > the same for now because DMI uses little-endian byte ordering and only
> > 2 flags are defined, however it will break if more flags are added in
> > the future.
> > 
> > This is the reason why I suggested passing WORD(data + 0x9) as the
> > parameter during my previous review.
> > 
> > Everything else is OK now, so I can fix that myself before committing
> > if that's OK with you.  
> 
> I'm sorry.  I missed that.  You're correct.  It should be:
> 
>       dmi_hp_238_flags("Management port", WORD(data + 0x9));

Fixed and committed. Thanks for your contribution!

-- 
Jean Delvare
SUSE L3 Support