[Dolibarr-dev] Migration from v2.9.0 to v3.1.0 - patch proposal

[Fernando Lagrange]

Hello all,

as this is my first post, let me quickly present myself:
I am part of Demo-TIC, a structure that uses, creates and promotes Free
Software.
We use Dolibarr since version 2.9.0, mainly for invoices, proposal and
structure's membership.


Dolibarr is very useful and always improving, which is great to see and
a pleasure to mention. :-)


With version 3.1.0  being released, I've updated our testing
installation from v2.9.0 to v3.1.0, following documentation and using
our production database.


All went smoothly on 2.9.0 to 3.0.0 update.
But on 3.0.0 to 3.1.0 two errors popped up on data migration (see
'3.0.0-3.1.0_data_migration_error' attached file).

Looking at upgrade process, it appeared that this was due to
2.9.0-3.0.0.sql and 3.0.0-3.1.0.sql scripts.

2.9.0-3.0.0.sql contains some comment lines starting with "--" that are
not followed by a space (mandatory following space is a mysql regression
bug, and I've seen that almost all of these lines have already been
corrected).

3.0.0-3.0.1.sql contains updates that made errors (unknown tables,
columns, and indexes, impossible for mysql to find meaning of
__DECRYPT('name')__  and so on).

So that you'll find a patch made upon latest git 3.1 branch of Dolibarr.
(Note that I did not removed last "insert into llx_c_actioncomm…" lines,
even though they were not needed on my installation.)

Can you please take attached git patch into account ?


Before looking deeper, I also wanted to know if this is normal
behaviour: mysql sql migration scripts made errors but upgrade process
do not alert administrator !?!



Keep up the good work !

Regards,
-- 
Fernando Lagrange
Demo-TIC - Outils En Ligne
http://www.demo-tic.org
Tél.: 06 63 16 30 47 (le jeudi après-midi)
Mél.: address@hidden
Jabber/XMPP: address@hidden

3.0.0-3.1.0-data_migration_error
Description: Text document

migration_from_2.9.0_to_3.1.0.patch
Description: Text Data

signature.asc
Description: OpenPGP digital signature