|
From: | Florian HENRY |
Subject: | [Dolibarr-dev] SQL guidelines into migration scirpt |
Date: | Fri, 6 Nov 2015 11:03:43 +0100 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
Hello All, During solving an issue https://github.com/Dolibarr/dolibarr/issues/3912 I've meet some bad SQL practice into core sql migration files. As dolibarr is PgSql comptabile we must keep in mind some SQL rules : for exemple ALTER TABLE llx_societe_rib ADD COLUMN frstrecur varchar(16) default 'FRST' after rum; will not work in pgsql (due to our SQL wrapper /core/db/pgsql.class.php) ALTER TABLE llx_societe_rib ADD COLUMN frstrecur varchar(16) DEFAULT 'FRST' AFTER rum; is the good syntax a PR is on is way with this fix on 3.8 branch https://github.com/Dolibarr/dolibarr/pull/3911 Should we include into test unit pgsql migration script ? Regards -- Florian Henry +33 6 03 76 48 07 address@hidden http://www.open-concept.pro Twitter : @_Open_Concept_ Google+ : https://www.google.com/+Open-conceptPro |
[Prev in Thread] | Current Thread | [Next in Thread] |