[debbugs-tracker] bug#13030: closed (factor: infinite loop on Linux/powerpc)

[GNU bug Tracking System]

Your message dated Thu, 29 Nov 2012 19:34:03 +0000
with message-id <address@hidden>
and subject line Re: bug#13030: factor: infinite loop on Linux/powerpc
has caused the debbugs.gnu.org bug report #13030,
regarding factor: infinite loop on Linux/powerpc
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
13030: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=13030
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> factor: infinite loop on Linux/powerpc
>
>
>
>
> Date: 
>
> Thu, 29 Nov 2012 14:28:18 +0000
>
>
>
>
> User-agent: 
>
> Mutt/1.5.21 (2010-09-15)
>
>
>
>
> Both Debian and Ubuntu builds of coreutils 8.20 hang while running the
> test suite on powerpc.  This turns out to be reproducible using 'factor
> 122'.
>
> This turns out to be somewhat related to
> http://debbugs.gnu.org/cgi/bugreport.cgi?bug=12754, but not quite the
> same.  uintmax_t is 64 bits, but the cntlzw instruction takes 32-bit
> operands, and the cntlzd option is only available on 64-bit hardware.  I
> believe the correct answer is to add an _LP64 check around the PPC64
> code, so that this falls back to the C implementations:
>
> --- coreutils-8.20~/src/longlong.h      2012-11-29 14:25:07.000000000 +0000
> +++ coreutils-8.20/src/longlong.h       2012-11-29 14:26:40.000000000 +0000
> @@ -1398,7 +1398,7 @@
>  
>  /* We should test _IBMR2 here when we add assembly support for the system
>     vendor compilers.  */
> -#if HAVE_HOST_CPU_FAMILY_powerpc && W_TYPE_SIZE == 64
> +#if HAVE_HOST_CPU_FAMILY_powerpc && W_TYPE_SIZE == 64 && defined (_LP64)
>  #if !defined (_LONG_LONG_LIMB)
>  /* _LONG_LONG_LIMB is ABI=mode32 where adde operates on 32-bit values.  So
>     use adde etc only when not _LONG_LONG_LIMB.  */
>
> Thanks,
>
> -- 
> Colin Watson                                       address@hidden
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#13030: factor: infinite loop on Linux/powerpc
>
>
>
>
> Date: 
>
> Thu, 29 Nov 2012 19:34:03 +0000
>
>
>
>
> User-agent: 
>
> Mozilla/5.0 (X11; Linux x86_64;	rv:13.0) Gecko/20120615 Thunderbird/13.0.1
>
>
>
>
> On 11/29/2012 02:28 PM, Colin Watson wrote:
> > Both Debian and Ubuntu builds of coreutils 8.20 hang while running the
> > test suite on powerpc.  This turns out to be reproducible using 'factor
> > 122'.
> >
> > This turns out to be somewhat related to
> > http://debbugs.gnu.org/cgi/bugreport.cgi?bug=12754, but not quite the
> > same.  uintmax_t is 64 bits, but the cntlzw instruction takes 32-bit
> > operands, and the cntlzd option is only available on 64-bit hardware.  I
> > believe the correct answer is to add an _LP64 check around the PPC64
> > code, so that this falls back to the C implementations:
> >
> > --- coreutils-8.20~/src/longlong.h      2012-11-29 14:25:07.000000000 +0000
> > +++ coreutils-8.20/src/longlong.h       2012-11-29 14:26:40.000000000 +0000
> > @@ -1398,7 +1398,7 @@
> >
> >   /* We should test _IBMR2 here when we add assembly support for the system
> >      vendor compilers.  */
> > -#if HAVE_HOST_CPU_FAMILY_powerpc && W_TYPE_SIZE == 64
> > +#if HAVE_HOST_CPU_FAMILY_powerpc && W_TYPE_SIZE == 64 && defined (_LP64)
> >   #if !defined (_LONG_LONG_LIMB)
> >   /* _LONG_LONG_LIMB is ABI=mode32 where adde operates on 32-bit values.  So
> >      use adde etc only when not _LONG_LONG_LIMB.  */
> >
> > Thanks,
>
> The fix looks good thanks.
> I'll commit that in your name along with this NEWS entry:
>
> ** Bug fixes
>
>   factor no longer hangs on 32 bit powerpc systems.
>   [bug introduced in coreutil-8.20]
>
> thanks,
> Pádraig.
>
>
> --- End Message ---