--- Begin Message ---
|
Subject: |
25.0.50; behaviour of read-directory-name with double slashes |
|
Date: |
Mon, 16 Nov 2015 07:27:51 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) |
After I eval:
(let ((default-directory "/tmp"))
(list (read-directory-name "foo" "/tmp/src/")
(read-directory-name "foo" "/tmp/src//")
(read-directory-name "foo" "src/")
(read-directory-name "foo" "src//")
(read-directory-name "foo" "foo//src/")
(read-directory-name "foo" "foo//src//")))
and hit RET RET RET RET, I get :
("/tmp/src/" "/" "src/" "/" "/src/" "/")
Is this intended ?
We could normalize the directory name via expand-file-name in all cases,
e.g. :
modified lisp/files.el
@@ -648,8 +648,7 @@ read-directory-name
(unless dir
(setq dir default-directory))
(read-file-name prompt dir (or default-dirname
- (if initial (expand-file-name initial dir)
- dir))
+ (expand-file-name (or initial "") dir))
mustmatch initial
'file-directory-p))
but the docstring states "Value is not expanded---you must call
`expand-file-name' yourself." so I guess the behaviour is important (and
I guess e.g. for tramp).
Should read-file-name be fixed or should the callers make sure to not
use double slashes ?
In GNU Emacs 25.0.50.1 (i686-pc-linux-gnu, X toolkit, Xaw scroll bars)
of 2015-11-14
Repository revision: ed2e7e20ae0945288c98091f308f5460c3453873
Windowing system distributor 'The X.Org Foundation', version 11.0.11501000
System Description: Ubuntu 14.04.3 LTS
--- End Message ---
--- Begin Message ---
|
Subject: |
Re: bug#21931: 25.0.50; behaviour of read-directory-name with double slashes |
|
Date: |
Mon, 23 Nov 2015 15:14:59 +0100 |
|
User-agent: |
mu4e 0.9.15; emacs 25.1.50.2 |
John Wiegley writes:
>>>>>> Nicolas Richard <address@hidden> writes:
>
>> ("/tmp/src/" "/" "src/" "/" "/src/" "/")
>> Is this intended ?
>
> What list were you expecting to see? "//" has always meant "start at root" to
> mean, ignoring whatever comes prior. This is how C-x C-f works, and it means
> you don't have to delete any existing default text in order to begin at root.
Indeed, but when constructing a path via (concat foo "/" bar), it can
happen that the result contains //. If this is then used as arg to
read-directory-name, this leads to an unexpected default.
OTOH (info "(elisp) Directory Names") explicitly says that using concat
for constructing paths in this way is wrong, so I guess that this bug
report is void.
Thanks for looking into it, I close it.
Nico.
--- End Message ---