[debbugs-tracker] bug#25741: closed (neo layout for kbd)

[GNU bug Tracking System]

Your message dated Thu, 25 May 2017 20:17:30 +0200
with message-id <address@hidden>
and subject line Re: bug#25741: [PATCH 2/2] gnu: kbd: Add neo layout.
has caused the debbugs.gnu.org bug report #25741,
regarding neo layout for kbd
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
25741: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=25741
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> neo layout for kbd
>
>
>
>
> Date: 
>
> Wed, 15 Feb 2017 16:46:14 +0000
>
>
>
>
> This adds two changes to the "kbd" package, to add the neo2 layout.
>
> I just configured a test system with it and it works.
>
> I'd prefer to find an smaller way to add the neo.map file, but this is
> functional for now.
>
>
> -- 
> ng0 -- https://www.inventati.org/patternsinthechaos/
>
>
>
> --- End Message ---

--- Begin Message --- Subject: Re: bug#25741: [PATCH 2/2] gnu: kbd: Add neo layout. Date: Thu, 25 May 2017 20:17:30 +0200 User-agent: Notmuch/0.24.1 (https://notmuchmail.org) Emacs/25.2.1 (x86_64-unknown-linux-gnu)

address@hidden writes:

> I updated with the changes you suggested and reconfigured my system with the 
> patches applied.
>
> Executing on tty1 as privileged user, "loadkeys neo" works and does what it 
> should do.
>
> Is it good to go now?

LGTM. I pushed this with a few minor changes:

--8<---------------cut here---------------start------------->8---
diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index ed1c6846b..2e984dd42 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -1662,15 +1662,16 @@ system.")
                    (let ((out (string-append %output "/share/keymaps"))
                          (source (assoc-ref %build-inputs "source")))
                      (mkdir-p out)
-                     (copy-file source (string-append out "/neo.map"))))))
+                     (copy-file source (string-append out "/neo.map"))
+                     #t))))
     (home-page "https://neo-layout.org";)
-    (synopsis "Neo2 console layout for loadkeys(1)")
+    (synopsis "Neo2 console layout")
     (description
-     "Kbd-neo provides the Neo2 keyboard layout for use with loadkeys(1)
-with kbd(4).")
+     "Kbd-neo provides the Neo2 keyboard layout for use with
address@hidden(1)} from @code{kbd(4)}.")
     ;; The file is located in an svn directory, the entire content of
     ;; the directory is licensed as GPL3.
-    (license license:gpl3)))
+    (license license:gpl3+)))
--8<---------------cut here---------------end--------------->8---

signature.asc
Description: PGP signature

--- End Message ---