[debbugs-tracker] bug#33407: closed (Cuirass is dropping the SQLite error message when rethrowing)

[GNU bug Tracking System]

Your message dated Fri, 16 Nov 2018 21:51:49 +0100
with message-id <address@hidden>
and subject line Re: bug#33407: Cuirass is dropping the SQLite error message 
when rethrowing
has caused the debbugs.gnu.org bug report #33407,
regarding Cuirass is dropping the SQLite error message when rethrowing
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
33407: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=33407
GNU Bug Tracking System
Contact address@hidden with problems

--- Begin Message --- Subject: Cuirass is dropping the SQLite error message when rethrowing Date: Fri, 16 Nov 2018 18:43:51 +0100

Hi,

is this a bug or by intention?

In src/cuirass/database.scm, in the db-add-* procedures, we have a
catch-clause like this:

(with-db-critical-section db
  (catch 'sqlite-error
    (lambda ()
      <thunk-body>)
    (lambda (key who code message . rest)
        ;; If we get a unique-constraint-failed error, that means we have
        ;; already inserted the same checkout.  That happens for each input
        ;; that doesn't change between two evaluations.
        (if (= code SQLITE_CONSTRAINT_PRIMARYKEY)
            #f
            (apply throw key who code rest))))))
-------------------------------------^

Here the message is not re-thrown.

It would have made my life easier if I saw this message:

  "NOT NULL constraint failed: Builds.system"

instead of just:

In cuirass/utils.scm:
   115:35  0 (_)
cuirass/utils.scm:115:35: Throw to key `sqlite-error' with args `(#f 1299)'.

Addationally, when adding the message to the apply clause, at least in
an isolated test it will be just thrown without problems.

Björn

pgpJ7u_j18aj1.pgp
Description: OpenPGP digital signature

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#33407: Cuirass is dropping the SQLite error message when rethrowing
>
>
>
>
> Date: 
>
> Fri, 16 Nov 2018 21:51:49 +0100
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
>
>
>
>
> Hello,
>
> Björn Höfling <address@hidden> skribis:
>
> > is this a bug or by intention?
> >
> > In src/cuirass/database.scm, in the db-add-* procedures, we have a
> > catch-clause like this:
> >
> > (with-db-critical-section db
> >   (catch 'sqlite-error
> >     (lambda ()
> >       <thunk-body>)
> >     (lambda (key who code message . rest)
> >         ;; If we get a unique-constraint-failed error, that means we have
> >         ;; already inserted the same checkout.  That happens for each input
> >         ;; that doesn't change between two evaluations.
> >         (if (= code SQLITE_CONSTRAINT_PRIMARYKEY)
> >             #f
> >             (apply throw key who code rest))))))
> > -------------------------------------^
> >
> > Here the message is not re-thrown.
> >
> > It would have made my life easier if I saw this message:
> >
> >   "NOT NULL constraint failed: Builds.system"
>
> Oops, good catch!  Fixed in commit
> d0ed3341d7201d0332e9aeb0af80e0ec635aeb1e.
>
> I also factorized the exception handler in the previous commit because
> there were 3 copies of this bug…
>
> Thanks!
>
> Ludo’.
>
>
> --- End Message ---