[debbugs-tracker] bug#35970: closed ([PATCH] gnu: Add qview.)

[GNU bug Tracking System]

Your message dated Wed, 05 Jun 2019 23:45:02 +0200
with message-id <address@hidden>
and subject line Re: [bug#35970] [PATCH] gnu: Add qview.
has caused the debbugs.gnu.org bug report #35970,
regarding [PATCH] gnu: Add qview.
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
35970: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=35970
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] gnu: Add qview.
>
>
>
>
> Date: 
>
> Wed, 29 May 2019 00:51:05 +0200
>
>
>
>
> * gnu/packages/image-viewers.scm (qview): New variable.
> ---
>  gnu/packages/image-viewers.scm | 48 ++++++++++++++++++++++++++++++++++
>  1 file changed, 48 insertions(+)
>
> diff --git a/gnu/packages/image-viewers.scm b/gnu/packages/image-viewers.scm
> index 82b44a4900..8dee417cdb 100644
> --- a/gnu/packages/image-viewers.scm
> +++ b/gnu/packages/image-viewers.scm
> @@ -9,6 +9,7 @@
>  ;;; Copyright © 2017 nee <address@hidden>
>  ;;; Copyright © 2018, 2019 Tobias Geerinckx-Rice <address@hidden>
>  ;;; Copyright © 2018, 2019 Ricardo Wurmus <address@hidden>
> +;;; Copyright © 2019 Nicolas Goaziou <address@hidden>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -429,3 +430,50 @@ imaging.  It supports several HDR and LDR image formats, 
> and it can:
>  a comic and manga reader.  It supports a variety of container formats
>  including CBZ, CB7, CBT, LHA.")
>      (license license:gpl2+)))
> +
> +(define-public qview
> +  (package
> +    (name "qview")
> +    (version "2.0")
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://github.com/jurplel/qView.git";)
> +                    (commit version)))
> +              (sha256
> +               (base32
> +                "1s29hz44rb5dwzq8d4i4bfg77dr0v3ywpvidpa6xzg7hnnv3mhi5"))))
> +    (build-system gnu-build-system)
> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         (replace 'configure
> +           (lambda _
> +             (invoke "qmake")))
> +         ;; Installation process hard-codes "/usr/bin", possibly
> +         ;; prefixed.
> +         (add-after 'configure 'fix-install-directory
> +           (lambda* (#:key outputs #:allow-other-keys)
> +             (let ((out (assoc-ref outputs "out")))
> +               (substitute* "Makefile"
> +                 (("\\$\\(INSTALL_ROOT\\)/usr") out))
> +               #t)))
> +         ;; Don't phone home or show "Checking for updates..." in the
> +         ;; About menu.
> +         (add-before 'build 'disable-auto-update
> +           (lambda _
> +             (substitute* "src/qvaboutdialog.cpp"
> +               (("ui->updateLabel->setText\\(updateText\\);") "")
> +               (("requestUpdates\\(\\);") ""))
> +             #t)))))
> +    (inputs
> +     `(("qtbase" ,qtbase)
> +       ("qtsvg" ,qtsvg)
> +       ("qtimageformats" ,qtimageformats)))
> +    (home-page "https://interversehq.com/qview/";)
> +    (synopsis "Practical and minimal image viewer")
> +    (description "qView is a Qt image viewer designed with visually
> +minimalism and usability in mind.  Its features include animated GIF
> +controls, file history, rotation/mirroring, and multithreaded
> +preloading.")
> +    (license license:gpl3+)))
> -- 
> 2.21.0
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [bug#35970] [PATCH] gnu: Add qview.
>
>
>
>
> Date: 
>
> Wed, 05 Jun 2019 23:45:02 +0200
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux)
>
>
>
>
> Hello,
>
> Ludovic Courtès <address@hidden> writes:
>
> > I commented because I was quite sure “convenient” was meant and because
> > “practical” is a false friend in French, but it’s no big deal.
> >
> > So please push with your preferred wording!  :-)
>
> Fair enough. I used "convenient" and pushed the commit.
>
> Thank you.
>
> Regards,
>
> -- 
> Nicolas Goaziou
>
>
> --- End Message ---