[debbugs-tracker] bug#36052: closed (26.2.50; [PATCH] Improve auth-source-pass)

[GNU bug Tracking System]

Your message dated Mon, 24 Jun 2019 17:33:28 +0300
with message-id <address@hidden>
and subject line Re: bug#36052: 26.2.50; [PATCH] Improve auth-source-pass
has caused the debbugs.gnu.org bug report #36052,
regarding 26.2.50; [PATCH] Improve auth-source-pass
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden.)


-- 
36052: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=36052
GNU Bug Tracking System
Contact address@hidden with problems

--- Begin Message --- Subject: 26.2.50; [PATCH] Improve auth-source-pass Date: Sun, 02 Jun 2019 11:11:15 +0200

Hi,

auth-source-pass users have worked hard to improve the package. Everyone
is on CC.

3 have signed the FSF paperwork:

- Keith Amidon:
  
https://github.com/DamienCassou/auth-password-store/pull/80#issuecomment-480853577
- Iku Iwasa:
  
https://github.com/DamienCassou/auth-password-store/pull/87#issuecomment-480816595
- galaunay:
  
https://github.com/DamienCassou/auth-password-store/pull/78#issuecomment-453862089

Magnus Henoch hasn't signed but his contribution is rather small (4
lines of a new unit-test and 2 lines of code). See patch 0001.

Here is a summary of the attached patches.

Damien Cassou (5):
  * lisp/auth-source-pass.el: Version 4.0.2
  * lisp/auth-source-pass.el (auth-source-pass-get): Add autoload
  Refactoring of auth-source-pass
  * lisp/auth-source-pass.el: Version 5.0.0
  * etc/NEWS: Describe changes to auth-source-pass

Iku Iwasa (1):
  Add auth-source-pass-port-separator option

Keith Amidon (4):
  Fix auth-source-pass to search for hostname:port/username
  Split out the attribute retrieval form auth-source-pass-get
  Minimize entry parsing in auth-source-pass
  * lisp/auth-source-pass.el: Add Keith Amidon to authors

Magnus Henoch (1):
  Fix auth-source-pass to return nil if no entry found

galaunay (1):
  Add auth-source-pass-path option

 etc/NEWS                            |  19 ++
 lisp/auth-source-pass.el            | 224 ++++++++-----
 test/lisp/auth-source-pass-tests.el | 473 +++++++++++++++++++---------
 3 files changed, 491 insertions(+), 225 deletions(-)

-- 
Damien Cassou
http://damiencassou.seasidehosting.st

"Success is the ability to go from one failure to another without
losing enthusiasm." --Winston Churchill

0001-Fix-auth-source-pass-to-return-nil-if-no-entry-found.patch
Description: Text Data

0002-lisp-auth-source-pass.el-Version-4.0.2.patch
Description: Text Data

0003-lisp-auth-source-pass.el-auth-source-pass-get-Add-au.patch
Description: Text Data

0004-Add-auth-source-pass-path-option.patch
Description: Text Data

0005-Add-auth-source-pass-port-separator-option.patch
Description: Text Data

0006-Fix-auth-source-pass-to-search-for-hostname-port-use.patch
Description: Text Data

0007-Split-out-the-attribute-retrieval-form-auth-source-p.patch
Description: Text Data

0008-Minimize-entry-parsing-in-auth-source-pass.patch
Description: Text Data

0009-lisp-auth-source-pass.el-Add-Keith-Amidon-to-authors.patch
Description: Text Data

0010-Refactoring-of-auth-source-pass.patch
Description: Text Data

0011-lisp-auth-source-pass.el-Version-5.0.0.patch
Description: Text Data

0012-etc-NEWS-Describe-changes-to-auth-source-pass.patch
Description: Text Data

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#36052: 26.2.50; [PATCH] Improve auth-source-pass
>
>
>
>
> Date: 
>
> Mon, 24 Jun 2019 17:33:28 +0300
>
>
>
>
> > From: Damien Cassou <address@hidden>
> > Cc: address@hidden, address@hidden, address@hidden, address@hidden, 
> > address@hidden, address@hidden, address@hidden, address@hidden
> > Date: Mon, 24 Jun 2019 09:26:04 +0200
> > 
> > Eli Zaretskii <address@hidden> writes:
> > > Thanks, these LGTM.
> > 
> > I've just pushed to master. Because it's my first time, can you please
> > check I did it right?
>
> You forgot to mention the bug number, AFAICT (happens to everyone from
> time to time).  Other than that, looks OK to me.
>
> > I guess this bug report can be closed now.
>
> Done.
>
> Thanks.
>
>
> --- End Message ---