emacs-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[debbugs-tracker] bug#36372: closed (27.0.50; replace-regexp-in-string s


From: GNU bug Tracking System
Subject: [debbugs-tracker] bug#36372: closed (27.0.50; replace-regexp-in-string skips START first chars in return value)
Date: Wed, 26 Jun 2019 17:42:04 +0000

Your message dated Wed, 26 Jun 2019 19:41:14 +0200
with message-id <address@hidden>
and subject line Re: bug#36372: 27.0.50; replace-regexp-in-string skips START 
first chars in return value [PATCH]
has caused the debbugs.gnu.org bug report #36372,
regarding 27.0.50; replace-regexp-in-string skips START first chars in return 
value
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden.)


-- 
36372: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=36372
GNU Bug Tracking System
Contact address@hidden with problems
--- Begin Message --- Subject: 27.0.50; replace-regexp-in-string skips START first chars in return value Date: Tue, 25 Jun 2019 14:01:49 +0200
From the doc string and the manual, the call

 (replace-regexp-in-string "a" "X" "abcab" t t nil 2)

would be expected to return

 "abcXb"

but the actual return value is

 "cXb"

This was probably not intended. The manual text is

 This function copies STRING and searches it for matches for REGEXP,
 and replaces them with REP.  It returns the modified copy.  If
 START is non-‘nil’, the search for matches starts at that index in
 STRING, so matches starting before that index are not changed.

The question is whether it is too late to fix the bug, or if it needs to be 
documented.

`string-match' + `replace-match' work as expected:

(let ((s "abcab"))
  (string-match "a" s 2)
  (replace-match "X" t t s))
=> "abcXb"

Bug#15107 is somewhat related.




--- End Message ---
--- Begin Message --- Subject: Re: bug#36372: 27.0.50; replace-regexp-in-string skips START first chars in return value [PATCH] Date: Wed, 26 Jun 2019 19:41:14 +0200
26 juni 2019 kl. 19.09 skrev Eli Zaretskii <address@hidden>:
> 
> LGTM, thanks.

That's it then. Thanks for the review; pushed.



--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]