[debbugs-tracker] bug#36880: closed ([PATCH] reconfigure: Reload all shepherd files when upgrading services.)

[GNU bug Tracking System]

Your message dated Fri, 2 Aug 2019 11:21:56 +0200
with message-id <address@hidden>
and subject line Re: [bug#36880] [PATCH] reconfigure: Reload all shepherd files 
when upgrading services.
has caused the debbugs.gnu.org bug report #36880,
regarding [PATCH] reconfigure: Reload all shepherd files when upgrading 
services.
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden.)


-- 
36880: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=36880
GNU Bug Tracking System
Contact address@hidden with problems

--- Begin Message --- Subject: [PATCH] reconfigure: Reload all shepherd files when upgrading services. Date: Wed, 31 Jul 2019 14:13:01 -0400 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux)

Fixes <https://bugs.gnu.org/36878>.
Reported by Robert Vollmert <address@hidden>.

* guix/scripts/system/reconfigure.scm (upgrade-shepherd-services): Load
all service files, rather than just those of services to be started.
---
 guix/scripts/system/reconfigure.scm | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/guix/scripts/system/reconfigure.scm 
b/guix/scripts/system/reconfigure.scm
index 8c7d461585..dee0c24bd2 100644
--- a/guix/scripts/system/reconfigure.scm
+++ b/guix/scripts/system/reconfigure.scm
@@ -161,12 +161,7 @@ services as defined by OS."
                                              target-services)
                                         (map live-service-canonical-name
                                              live-services)))
-             (service-files
-              (map shepherd-service-file
-                   (filter (lambda (service)
-                             (memq (shepherd-service-canonical-name service)
-                                   to-start))
-                           target-services))))
+             (service-files (map shepherd-service-file target-services)))
         (eval #~(primitive-load #$(upgrade-services-program service-files
                                                             to-start
                                                             to-unload
-- 
2.22.0

signature.asc
Description: PGP signature

--- End Message ---

--- Begin Message --- Subject: Re: [bug#36880] [PATCH] reconfigure: Reload all shepherd files when upgrading services. Date: Fri, 2 Aug 2019 11:21:56 +0200

I've pushed that patch to guix master as commit 
1db6f137d93b59409fedb3deb24c876649e1b8f2 now.

Thanks!

pgpVzxr4Fo67f.pgp
Description: Digitale Signatur von OpenPGP

--- End Message ---