emacs-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[debbugs-tracker] bug#36559: closed ([PATCH] add rednotebook)


From: GNU bug Tracking System
Subject: [debbugs-tracker] bug#36559: closed ([PATCH] add rednotebook)
Date: Thu, 29 Aug 2019 17:19:02 +0000

Your message dated Thu, 29 Aug 2019 19:18:18 +0200
with message-id <address@hidden>
and subject line Re: [bug#36559] [PATCH] add rednotebook
has caused the debbugs.gnu.org bug report #36559,
regarding [PATCH] add rednotebook
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden.)


-- 
36559: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=36559
GNU Bug Tracking System
Contact address@hidden with problems
--- Begin Message --- Subject: [PATCH] add rednotebook Date: Mon, 8 Jul 2019 22:22:08 -0600
Patch is attached.
As explained in the comment I had to correct a few problems:
1. Tests always fail, but (in my experience) the final application is
stable.
2. rednotebook  uses the GI_TYPELIB_PATH and LD_LIBRARY_PATH to find
webkitgtk.

Furthermore:

- The commit message was killed/yanked from commit
  072e986ec808690db991e018d6ceee868b5b5f4a and adjusted.

- I made gnu/packages/journal.scm to add other similar journal/diary
  applications. Because I do not like naming sources for the only
  package defined within, especially when the package is simple, I
  recommend moving the jrnl package definition to it. Say the word and
  I will produce the patch to do this. Perhaps we should discuss the
  idea of organizing packages by function on the devel mailing list?

  - I also plan to define a package for other journal applications
    (like those listed between rednotebook and jrnl at
    <https://www.maketecheasier.com/best-journal-apps-for-linux/> and
    any other recommendations).

Knowing I am likely to err, I expect you (whoever reviews this patch)
to point out everything you don't like so I can fix it before you
approve and commit to savannah ;)

Thanks,
-Jesse

Attachment: 0001-gnu-Add-rednotebook.patch
Description: Text Data


--- End Message ---
--- Begin Message --- Subject: Re: [bug#36559] [PATCH] add rednotebook Date: Thu, 29 Aug 2019 19:18:18 +0200 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux)
Hello,

Jesse Gibbons <address@hidden> writes:

> From a5967bdbd15987438f158f1ae9bac2dc5a44c645 Mon Sep 17 00:00:00 2001
> From: Jesse Gibbons <address@hidden>
> Date: Wed, 28 Aug 2019 20:35:29 -0600
> Subject: [PATCH] gnu: Add rednotebook.
>
>     * gnu/package/rednotebook.scm: New file.
>     * gnu/local.mk: Add it.
>     * gnu/packages/rednotebook.scm (rednotebook): New variable.

Applied. Thank you!

Regards,

-- 
Nicolas Goaziou


--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]