bug#39523: closed ([PATCH] gnu: password-store: Install fish and zsh completions.)

[GNU bug Tracking System]

Your message dated Mon, 10 Feb 2020 01:10:50 +0100
with message-id <address@hidden>
and subject line Re: [bug#39523] [PATCH] gnu: password-store: Install fish and 
zsh completions.
has caused the debbugs.gnu.org bug report #39523,
regarding [PATCH] gnu: password-store: Install fish and zsh completions.
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden.)


-- 
39523: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=39523
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] gnu: password-store: Install fish and zsh completions.
>
>
>
>
> Date: 
>
> Sun,  9 Feb 2020 10:11:25 +0100
>
>
>
>
> * gnu/packages/password-utils.scm (password-store)[arguments]: Remove
> phase install-shell-completions. Adjust make-flags.
> ---
>  gnu/packages/password-utils.scm | 14 ++++----------
>  1 file changed, 4 insertions(+), 10 deletions(-)
>
> diff --git a/gnu/packages/password-utils.scm b/gnu/packages/password-utils.scm
> index db5f54e1d9..9cfa5ed3a3 100644
> --- a/gnu/packages/password-utils.scm
> +++ b/gnu/packages/password-utils.scm
> @@ -496,17 +496,11 @@ any X11 window.")
>                                  "sed" "tree" "which" "xclip"))))
>                 (wrap-program (string-append out "/bin/pass")
>                   `("PATH" ":" prefix (,(string-join path ":"))))
> -               #t)))
> -         (add-after 'wrap-path 'install-shell-completions
> -           (lambda* (#:key outputs #:allow-other-keys)
> -             (let* ((out      (assoc-ref outputs "out"))
> -                    (bashcomp (string-append out "/etc/bash_completion.d")))
> -               ;; TODO: install fish and zsh completions.
> -               (mkdir-p bashcomp)
> -               (copy-file "src/completion/pass.bash-completion"
> -                          (string-append bashcomp "/pass"))
>                 #t))))
> -       #:make-flags (list "CC=gcc" (string-append "PREFIX=" %output))
> +       #:make-flags (list "CC=gcc" (string-append "PREFIX=" %output)
> +                          "WITH_ALLCOMP=yes"
> +                          (string-append "BASHCOMPDIR="
> +                                         %output "/etc/bash_completion.d"))
>         ;; Parallel tests may cause a race condition leading to a
>         ;; timeout in some circumstances.
>         #:parallel-tests? #f
> -- 
> 2.24.1
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [bug#39523] [PATCH] gnu: password-store: Install fish and zsh completions.
>
>
>
>
> Date: 
>
> Mon, 10 Feb 2020 01:10:50 +0100
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)
>
>
>
>
> Hello,
>
> Brice Waegeneire <address@hidden> writes:
>
> > * gnu/packages/password-utils.scm (password-store)[arguments]: Remove
> > phase install-shell-completions. Adjust make-flags.
>
> I applied your patch (as df931ac39c40ac8a702e37cb434d9a1016606ed7)...
> aaaaaaaand added a copyright line. Phew :)
>
> Thank you!
>
> Regards,
>
> -- 
> Nicolas Goaziou
>
>
> --- End Message ---