bug#39627: closed ([PATCH] Skip shell prompt on current line even if it's protected)

[GNU bug Tracking System]

Your message dated Fri, 21 Feb 2020 10:56:11 +0200
with message-id <address@hidden>
and subject line Re: bug#39627: [PATCH] Skip shell prompt on current line even 
if it's protected
has caused the debbugs.gnu.org bug report #39627,
regarding [PATCH] Skip shell prompt on current line even if it's protected
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden.)


-- 
39627: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=39627
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] Skip shell prompt on current line even if it's protected
>
>
>
>
> Date: 
>
> Sat, 15 Feb 2020 15:13:59 -0800
>
>
>
>
> * lisp/eshell/em-prompt.el (eshell-previous-prompt): Really go to the
> beginning of the line, even if it's protected.
>
> When the eshell prompt is protected (e.g., with rear non-sticky,
> inhibited movements, etc.), `beginning-of-line' won't move to the
> actual beginning of the line and therefore won't skip over the
> prompt.  This change simply switches to (forward-line 0).
> ---
>  lisp/eshell/em-prompt.el | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lisp/eshell/em-prompt.el b/lisp/eshell/em-prompt.el
> index 25b8ccaba17..9ae5ae12816 100644
> --- a/lisp/eshell/em-prompt.el
> +++ b/lisp/eshell/em-prompt.el
> @@ -187,7 +187,7 @@ See `eshell-prompt-regexp'."
>    "Move to end of Nth previous prompt in the buffer.
>  See `eshell-prompt-regexp'."
>    (interactive "p")
> -  (beginning-of-line)            ; Don't count prompt on current line.
> +  (forward-line 0)            ; Don't count prompt on current line.
>    (eshell-next-prompt (- n)))
>  
>  (defun eshell-skip-prompt ()
> -- 
> 2.25.0
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#39627: [PATCH] Skip shell prompt on current line even if it's protected
>
>
>
>
> Date: 
>
> Fri, 21 Feb 2020 10:56:11 +0200
>
>
>
>
> > From: Steven Allen <address@hidden>
> > Date: Sat, 15 Feb 2020 15:13:59 -0800
> > 
> > * lisp/eshell/em-prompt.el (eshell-previous-prompt): Really go to the
> > beginning of the line, even if it's protected.
> > 
> > When the eshell prompt is protected (e.g., with rear non-sticky,
> > inhibited movements, etc.), `beginning-of-line' won't move to the
> > actual beginning of the line and therefore won't skip over the
> > prompt.  This change simply switches to (forward-line 0).
>
> Thanks, pushed to the emacs-27 branch.
>
> Please note that I needed to massage your log message a little, to
> make it more according to our conventions (described in CONTRIBUTE).
> Please study the changes I made and try to follow this style in the
> future.
>
>
> --- End Message ---