bug#39754: closed ([PATCH] gnu: z3: Build the Python bindings)

[GNU bug Tracking System]

Your message dated Sun, 23 Feb 2020 17:59:56 +0100
with message-id <20200223165956.fwhqktyn4z5exnrr@gravity>
and subject line Re: [bug#39754] [PATCH v2] gnu: z3: Build the Python bindings
has caused the debbugs.gnu.org bug report #39754,
regarding [PATCH] gnu: z3: Build the Python bindings
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden.)


-- 
39754: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=39754
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] gnu: z3: Build the Python bindings
>
>
>
>
> Date: 
>
> Sun, 23 Feb 2020 16:14:10 +0100
>
>
>
>
> * gnu/packages/maths.scm (z3)[arguments]: Add the --python and
>   --pypkgdir flags to configure.
> ---
>  gnu/packages/maths.scm | 11 +++++++++--
>  1 file changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/gnu/packages/maths.scm b/gnu/packages/maths.scm
> index 535ba02ea6..db2dc2a884 100644
> --- a/gnu/packages/maths.scm
> +++ b/gnu/packages/maths.scm
> @@ -4181,7 +4181,12 @@ as equations, scalars, vectors, and matrices.")
>                  "0hprcdwhhyjigmhhk6514m71bnmvqci9r8gglrqilgx424r6ff7q"))))
>      (build-system gnu-build-system)
>      (arguments
> -     `(#:phases
> +     `(#:imported-modules ((guix build python-build-system)
> +                           ,@%gnu-build-system-modules)
> +       #:modules ((guix build python-build-system)
> +                  (guix build gnu-build-system)
> +                  (guix build utils))
> +       #:phases
>         (modify-phases %standard-phases
>           (add-after 'unpack 'fix-compatability
>             ;; Versions after 4.8.3 have immintrin.h IFDEFed for Windows only.
> @@ -4198,7 +4203,9 @@ as equations, scalars, vectors, and matrices.")
>           (replace 'configure
>             (lambda* (#:key inputs outputs #:allow-other-keys)
>               (invoke "./configure"
> -                     (string-append "--prefix=" (assoc-ref outputs "out")))))
> +                     "--python"
> +                     (string-append "--prefix=" (assoc-ref outputs "out"))
> +                     (string-append "--pypkgdir=" (site-packages inputs 
> outputs)))))
>           (add-after 'configure 'change-directory
>             (lambda _
>               (chdir "build")
> -- 
> 2.25.0
>
>
>
>
> --- End Message ---

--- Begin Message --- Subject: Re: [bug#39754] [PATCH v2] gnu: z3: Build the Python bindings Date: Sun, 23 Feb 2020 17:59:56 +0100

On Sun, Feb 23, 2020 at 05:48:48PM +0100, Ludovic Courtès wrote:
> Hi!
> 
> Jakub Kądziołka <address@hidden> skribis:
> 
> > * gnu/packages/maths.scm (z3)[arguments]: Add the --python and
> >   --pypkgdir flags to configure.
> 
> Could you also mention the addition of #:modules and #:imported-modules?
Sure thing!

> 
> > Changed the #:modules argument to only import site-packages from (guix
> > build python-build-system) as, as Ludo' pointed out on IRC, it also
> > exports %standard-phases, which could conflict with (guix build
> > gnu-build-system).
> >
> > I considered putting the Python bindings in a separate output; I decided 
> > not to
> > do so as this change increases `guix size z3' from 116.4 MiB to 117.5
> > MiB, which is barely noticeable.
> 
> Makes sense to me.
> 
> LGTM, thanks!
Thanks! Pushed:

commit f6b4d395fd321d43fd548ba832c78320ac3f8d51
Author: Jakub Kądziołka <address@hidden>
Date:   Sun Feb 23 16:11:30 2020 +0100

    gnu: z3: Build the Python bindings

    * gnu/packages/maths.scm (z3)[arguments]: Add the --python and
      --pypkgdir flags to configure. To facilitate the latter, add
      (guix build python-build-system) to #:modules and #:imported-modules.

signature.asc
Description: PGP signature

--- End Message ---