bug#39758: closed ([PATCH] Add qtbase-patched. (Fix QTBUG-81715))

[GNU bug Tracking System]

Your message dated Mon, 24 Feb 2020 18:16:14 +0100
with message-id <address@hidden>
and subject line Re: [bug#39758] [PATCH] Add qtbase-patched. (Fix QTBUG-81715)
has caused the debbugs.gnu.org bug report #39758,
regarding [PATCH] Add qtbase-patched. (Fix QTBUG-81715)
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden.)


-- 
39758: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=39758
GNU Bug Tracking System
Contact address@hidden with problems

--- Begin Message --- Subject: [PATCH] Add qtbase-patched. (Fix QTBUG-81715) Date: Sun, 23 Feb 2020 17:41:29 +0000

Hi Guix,

There is a known issue in qtbase 5.12.7 where the cmake macros shipped
with qt do not work when paths include dots.  This broke freecad and
maybe others.

I am not sure how to figure out other broken packages, if they need to
use the patched-qtbase.

Thanks,

John

0001-gnu-Add-qtbase-QTBUG-81715.patch.-Fixes-QTBUG-81715.patch
Description: Text Data

0002-gnu-Add-qtbase-patched.patch
Description: Text Data

0003-gnu-freecad.-Fix-build-failures.patch
Description: Text Data

0004-gnu-freecad.-Use-qt-build-system.patch
Description: Text Data

--- End Message ---

--- Begin Message --- Subject: Re: [bug#39758] [PATCH] Add qtbase-patched. (Fix QTBUG-81715) Date: Mon, 24 Feb 2020 18:16:14 +0100 User-agent: Notmuch/0.29.3 (https://notmuchmail.org) Emacs/26.3 (x86_64-pc-linux-gnu)

John Soo <address@hidden> writes:

> Hi Guix,
>
> There is a known issue in qtbase 5.12.7 where the cmake macros shipped
> with qt do not work when paths include dots.  This broke freecad and
> maybe others.

Thanks!  I've pushed the patches with a few modifications in
e2546bb472b6285a8856cacf686c5e0ce9bb62c5 and
3c60d85f313f910282ed884eead80061faf6ee78.

I will move the patch to the regular qtbase package on the 'staging'
branch later to avoid the custom variant.

> I am not sure how to figure out other broken packages, if they need to
> use the patched-qtbase.

Typically you'd have to do 'guix refresh -l qtbase' and copy-paste the
package list to a 'guix build' invokation.  IWBN to have a single
command for that.

[...]
  
> From 92ba3b59a2ff1dd6b4078c649a468fa208b47a59 Mon Sep 17 00:00:00 2001
> From: John Soo <address@hidden>
> Date: Fri, 21 Feb 2020 21:14:57 -0800
> Subject: [PATCH 3/4] gnu: freecad. Fix build failures.
>
> * gnu/packages/engineering.scm (freecad): [supported-systems] Only support 
> aarch64 and
> x86_64-linux, [inputs] use qtbase-patched instead of qtbase.

I dropped the [supported-systems] change as it seems unrelated to the
qtbase problem.  Could you submit it as a separate patch, ideally with a
comment that explains why we do it (i.e. "upstream only supports
64-bit platforms")?

signature.asc
Description: PGP signature

--- End Message ---