bug#42528: closed ([PATCH] gnu: beets: Support replaygain plugin)

[GNU bug Tracking System]

Your message dated Sat, 25 Jul 2020 18:47:10 +0200
with message-id <87h7tvsfsh.fsf@gnu.org>
and subject line Re: [bug#42528] [PATCH] gnu: beets: Support replaygain plugin
has caused the debbugs.gnu.org bug report #42528,
regarding [PATCH] gnu: beets: Support replaygain plugin
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
42528: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=42528
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] gnu: beets: Support replaygain plugin
>
>
>
>
> Date: 
>
> Sat, 25 Jul 2020 10:37:16 +0200
>
>
>
>
> * gnu/packages/music.scm (beets)[arguments]: Add 'wrap-typelib phase
> [inputs]: Add gstreamer, plugins and python-pygobject
> ---
>  gnu/packages/music.scm | 22 ++++++++++++++++++++--
>  1 file changed, 20 insertions(+), 2 deletions(-)
>
> diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
> index fcdacb66be..f4cecb07ca 100644
> --- a/gnu/packages/music.scm
> +++ b/gnu/packages/music.scm
> @@ -3024,7 +3024,19 @@ websites such as Libre.fm.")
>               #t))
>           (replace 'check
>             (lambda _
> -             (invoke "nosetests" "-v"))))))
> +             (invoke "nosetests" "-v")))
> +         ;; Wrap the executable, so it can find python-gi (aka pygobject) and
> +         ;; gstreamer plugins.
> +         (add-after 'wrap 'wrap-typelib
> +           (lambda* (#:key outputs #:allow-other-keys)
> +             (let ((prog (string-append (assoc-ref outputs "out")
> +                                        "/bin/beet"))
> +                   (plugins (getenv "GST_PLUGIN_SYSTEM_PATH"))
> +                   (types (getenv "GI_TYPELIB_PATH")))
> +               (wrap-program prog
> +                 `("GST_PLUGIN_SYSTEM_PATH" ":" prefix (,plugins))
> +                 `("GI_TYPELIB_PATH" ":" prefix (,types)))
> +               #t))))))
>      (native-inputs
>       `(("python-beautifulsoup4" ,python-beautifulsoup4)
>         ("python-flask" ,python-flask)
> @@ -3045,7 +3057,13 @@ websites such as Libre.fm.")
>         ("python-mutagen" ,python-mutagen)
>         ("python-pyacoustid" ,python-pyacoustid)
>         ("python-pyyaml" ,python-pyyaml)
> -       ("python-unidecode" ,python-unidecode)))
> +       ("python-unidecode" ,python-unidecode)
> +       ;; For plugin replaygain.
> +       ("python-pygobject" ,python-pygobject)
> +       ("gobject-introspection" ,gobject-introspection)
> +       ("gst-plugins-base" ,gst-plugins-base)
> +       ("gst-plugins-good" ,gst-plugins-good)
> +       ("gstreamer" ,gstreamer)))
>      (home-page "https://beets.io";)
>      (synopsis "Music organizer")
>      (description "The purpose of beets is to get your music collection right
> -- 
> 2.26.2
>
>
>
>
> --- End Message ---

--- Begin Message --- Subject: Re: [bug#42528] [PATCH] gnu: beets: Support replaygain plugin Date: Sat, 25 Jul 2020 18:47:10 +0200

Lars-Dominik Braun <lars@6xq.net> writes:

> * gnu/packages/music.scm (beets)[arguments]: Add 'wrap-typelib phase
> [inputs]: Add gstreamer, plugins and python-pygobject

I adjusted the commit message to have punctuations and mention all the
added inputs.

Applied, thanks!

signature.asc
Description: PGP signature

--- End Message ---