--- Begin Message ---
|
Subject: |
[PATCH 0/3] Fix non-recursive importers gnu and json |
|
Date: |
Tue, 19 Jan 2021 16:25:18 +0100 |
Dear,
The first patch is cosmetic. Even, the file guix/import/gnu.scm should not
contain UI messages, IMHO. Another story.
The two other patches fix the ugly backtrace throw by:
guix import gnu do-not-exist
guix import json do-no-exist
with something like:
--8<---------------cut here---------------start------------->8---
$ ./pre-inst-env guix import gnu do-not-exist
guix import: error: failed to determine latest release of GNU do-not-exist
$ ./pre-inst-env guix import json do-not-exist
guix import: error: invalid file name
--8<---------------cut here---------------end--------------->8---
See bug#44115 <http://issues.guix.gnu.org/44115#3> for details about the bug.
All the best,
simon
zimoun (3):
import: gnu: Add internationalized messages.
guix: gnu-maintenance: Fix error handling.
scripts: import: json: Fix error handling.
guix/gnu-maintenance.scm | 5 ++++-
guix/import/gnu.scm | 11 +++++++++--
guix/scripts/import/json.scm | 7 +++++--
3 files changed, 18 insertions(+), 5 deletions(-)
base-commit: 2d9c6542c804eb2ef3d8934e1e3ab8b24e9bbafb
--
2.29.2
--- End Message ---
--- Begin Message ---
|
Subject: |
Re: bug#45983: [PATCH 0/3] Fix non-recursive importers gnu and json |
|
Date: |
Sun, 31 Jan 2021 21:37:26 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) |
Hi!
I applied the whole series.
zimoun <zimon.toutoune@gmail.com> skribis:
> * guix/import/gnu.scm (gnu->guix-package): Add 'G_' to messages.
Two comments: (1) things like (message "string") are already i18n’d, and
(2):
> + (raise (make-compound-condition
> + (formatted-message
> + (G_ "failed to determine latest release of GNU ~a")
> + name))))))
I removed ‘make-compound-condition’, which is unnecessary here.
Thanks!
Ludo’.
--- End Message ---