bug#51838: closed ([PATCH 00/11] guix: node-build-system: Support compiling add-ons with node-gyp.)

[GNU bug Tracking System]

Your message dated Sun, 09 Jan 2022 02:19:30 +0100
with message-id <92d499642b68db88a913c407e95a2374e208c517.camel@gmail.com>
and subject line Re: [PATCH v9 00/41] guix: node-build-system: Support 
compiling add-ons with node-gyp.
has caused the debbugs.gnu.org bug report #51838,
regarding [PATCH 00/11] guix: node-build-system: Support compiling add-ons with 
node-gyp.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
51838: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=51838
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH 00/11] guix: node-build-system: Support compiling add-ons with node-gyp.
>
>
>
>
> Date: 
>
> Sun, 14 Nov 2021 07:41:51 -0500
>
>
>
>
> This patch series adds support to `node-build-system` for building native
> add-ons using `node-gyp`. To confirm that the changes to the build system
> work, the patch series also adds two packages (plus a few dependencies)
> representing two major ways of writing Node.js native add-ons:
>
>  1. `node-openzwave-shared` uses `node-nan`: “Native Abstractions for Node.js”.
>
>  2. `node-sqlite3` uses the Node-API via `node-addon-api`.
>
> The patches are adapted from part of a series by Pierre Langlois
> at <https://issues.guix.gnu.org/49946>: you can find discussion of an earlier
> version of this spun-off series from <https://issues.guix.gnu.org/49946#71>
> to <https://issues.guix.gnu.org/49946#83>.
> They are also available in a Git repository
> at <https://gitlab.com/philip1/guix-patches/-/tree/wip-node-npm-gyp-hist-9>.
>
> In the earlier discussion, Pierre and I both thought it was quite confusing
> that the Scheme variable `node` refers to the bootstrap Node.js, while
> `node-lts` refers to the newer Node.js that a package specification of
> `"node"` would resolve to. My analysis is
> at <https://issues.guix.gnu.org/49946#75> (tl;dr it seems like an unintentional
> mistake), and Pierre suggested a solution
> in <https://issues.guix.gnu.org/49946#81>. I haven't taken that on in this patch
> series, but I do think its worth considering.
>
> Philip McGrath (11):
>   gnu: node: Avoid duplicating build phases.
>   gnu: node: Update to 10.24.1 for bootstrapping.
>   guix: node-build-system: Support compiling add-ons with node-gyp.
>   gnu: Add node-inherits.
>   gnu: Add node-safe-buffer.
>   gnu: Add node-string-decoder.
>   gnu: Add node-readable-stream.
>   gnu: Add node-nan.
>   gnu: Add node-openzwave-shared.
>   gnu: Add node-addon-api.
>   gnu: Add node-sqlite3.
>
>  gnu/packages/node-xyz.scm        | 335 +++++++++++++++++++++++++++++++
>  gnu/packages/node.scm            | 143 +++++--------
>  gnu/packages/zwave.scm           |  55 +++++
>  guix/build-system/node.scm       |  11 +-
>  guix/build/node-build-system.scm |  23 +++
>  5 files changed, 473 insertions(+), 94 deletions(-)
>
> -- 
> 2.32.0
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [PATCH v9 00/41] guix: node-build-system: Support compiling add-ons with node-gyp.
>
>
>
>
> Date: 
>
> Sun, 09 Jan 2022 02:19:30 +0100
>
>
>
>
> User-agent: 
>
> Evolution 3.42.1 
>
>
>
>
> Am Samstag, dem 08.01.2022 um 10:33 -0500 schrieb Philip McGrath:
> > My intention was to acknowledge that the basic approach of 
> > 'delete-dependencies' was your idea. But, again, whatever you like!
> That hardly counts as intellectual property in my opinion, it's not
> like I revolutionized anything in the scope of Guix.
>
> The new node-build-system is live now, so you can rewrite JSON and
> delete dependencies as much as you want on master.  Please allow for
> other users to actually make use of it before writing up your next
> proposal.  We'll only be able to see our shortcomings by having a large
> number of people try it in the real world.
>
> Thanks and good night :)
>
>
> --- End Message ---