bug#53086: closed ([PATCH 12/41] gnu: rust-rbw: adding rust-sha2-0.10)

[GNU bug Tracking System]

Your message dated Wed, 19 Jan 2022 14:29:32 +0100
with message-id <87zgnretvn.fsf@nicolasgoaziou.fr>
and subject line Re: [bug#53075] [PATCH 1/41] gnu: rust-rbw: adding 
rust-zeroize-1.4
has caused the debbugs.gnu.org bug report #53075,
regarding [PATCH 12/41] gnu: rust-rbw: adding rust-sha2-0.10
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
53075: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=53075
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH 12/41] gnu: rust-rbw: adding rust-sha2-0.10
>
>
>
>
> Date: 
>
> Fri, 07 Jan 2022 15:04:37 +0100
>
>
>
>
> User-agent: 
>
> mu4e 1.6.10; emacs 28.0.50
>
>
>
>
> >From 8418829087ce32b784943ff3311b98d42fea69fa Mon Sep 17 00:00:00 2001
> From: Nicolas Graves <ngraves@ngraves.fr>
> Date: Fri, 7 Jan 2022 02:39:27 +0100
> Subject: [PATCH 13/42] rust-rbw dependencies : adding rust-sha2-0.10
>
> ---
>  gnu/packages/crates-io.scm | 21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)
>
> diff --git a/gnu/packages/crates-io.scm b/gnu/packages/crates-io.scm
> index 86a361cfc6..01d74e5cdb 100644
> --- a/gnu/packages/crates-io.scm
> +++ b/gnu/packages/crates-io.scm
> @@ -49820,6 +49820,27 @@ (define-public rust-sha2-0.9
>  function family including SHA-224, SHA-256, SHA-384, and SHA-512.")
>      (license (list license:expat license:asl2.0))))
>  
> +(define-public rust-sha2-0.10
> +  (package
> +    (inherit rust-sha2-0.9)
> +    (name "rust-sha2")
> +    (version "0.10.0")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (crate-uri "sha2" version))
> +       (file-name (string-append name "-" version ".tar.gz"))
> +       (sha256
> +        (base32 "1dnw5dfp4bbsxjz2nkx5d54vgsig0x66jd9b5z7mpcbbsd6rc3ch"))))
> +    (arguments
> +     `(#:skip-build?
> +       #t
> +       #:cargo-inputs
> +       (("rust-cfg-if" ,rust-cfg-if-1)
> +        ("rust-cpufeatures" ,rust-cpufeatures-0.2)
> +        ("rust-digest" ,rust-digest-0.10)
> +        ("rust-sha2-asm" ,rust-sha2-asm-0.6))))))
> +
>  (define-public rust-sha2-0.8
>    (package
>      (inherit rust-sha2-0.9)
> -- 
> 2.34.0
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [bug#53075] [PATCH 1/41] gnu: rust-rbw: adding rust-zeroize-1.4
>
>
>
>
> Date: 
>
> Wed, 19 Jan 2022 14:29:32 +0100
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
>
>
>
>
> Hello,
>
> Nicolas Graves via Guix-patches via <guix-patches@gnu.org> writes:
>
> > From 117ac2e745d1e9e2122bdf5859ae2b2781ca01c4 Mon Sep 17 00:00:00 2001
> > From: Nicolas Graves <ngraves@ngraves.fr>
> > Date: Thu, 6 Jan 2022 23:16:42 +0100
> > Subject: [PATCH 02/42] rust-rbw dependencies : adding rust-zeroize-1.4
>
> Thank you. First some general notes about your patches.
>
> The first thing is that your patch set should have gone under the same
> bug number. You created more than 40 bugs for rbw. You may want to look
> at "Contributing" section of the Guix manual for details.
>
> Also, commit messages are normalized in Guix. You should look at what
> I wrote instead of yours to get a feel about it.
>
> Eventually, descriptions should consist of full sentences.
>
> Now about this patch.
>
> Unless under exceptional circumstances, we don't add a new package for
> a change below the first non-zero digit. In this case, the common way is
> to simply update rust-zeroize-1 to 1.4.3.
>
> Therefore, I dropped this patch and did the above.
>
> Regards,
> -- 
> Nicolas Goaziou
>
>
> --- End Message ---