bug#53430: closed (28.0.91; eudc-expand-inline fails in BBDB backend with void records variable)

[GNU bug Tracking System]

Your message dated Sat, 22 Jan 2022 10:04:12 -0500
with message-id <m3k0erhkwj.fsf@fitzsim.org>
and subject line Re: bug#53430: 28.0.91; eudc-expand-inline fails in BBDB 
backend with void records variable
has caused the debbugs.gnu.org bug report #53430,
regarding 28.0.91; eudc-expand-inline fails in BBDB backend with void records 
variable
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
53430: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=53430
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems

--- Begin Message --- Subject: 28.0.91; eudc-expand-inline fails in BBDB backend with void records variable Date: Fri, 21 Jan 2022 18:08:13 -0500

Hi,

I updated to the emacs-28 branch recently.  When I first tried to
complete an e-mail address using eudc-expand-inline I saw this error:

    Symbol's value as variable is void: records

It turned out to be a quoting issue in eudc-bbdb-query-internal in the
EUDC BBDB backend.  It looks like this was introduced by the change to
lexical-binding.  The attached patch fixes the issue (though, the
quoting that works now is different from what was there before the
lexical-binding change).

Does it look OK to push to emacs-28?

Thanks,
Thomas

0001-EUDC-Fix-a-quoting-bug-in-the-BBDB-backend.patch
Description: Text Data

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#53430: 28.0.91; eudc-expand-inline fails in BBDB backend with void records variable
>
>
>
>
> Date: 
>
> Sat, 22 Jan 2022 10:04:12 -0500
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)
>
>
>
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> >> From: Thomas Fitzsimmons <fitzsim@fitzsim.org>
> >> Date: Fri, 21 Jan 2022 18:08:13 -0500
> >> 
> >> I updated to the emacs-28 branch recently.  When I first tried to
> >> complete an e-mail address using eudc-expand-inline I saw this error:
> >> 
> >>     Symbol's value as variable is void: records
> >> 
> >> It turned out to be a quoting issue in eudc-bbdb-query-internal in the
> >> EUDC BBDB backend.  It looks like this was introduced by the change to
> >> lexical-binding.  The attached patch fixes the issue (though, the
> >> quoting that works now is different from what was there before the
> >> lexical-binding change).
> >> 
> >> Does it look OK to push to emacs-28?
> >
> > Yes, thanks.
>
> Done, thanks.
>
> Thomas
>
>
> --- End Message ---