--- Begin Message ---
|
Subject: |
[PATCH] gnu: python-daemon: Fix build by temporarily disabling the tests. |
|
Date: |
Thu, 3 Mar 2022 11:58:52 +0100 |
A test is failing due to a new version of a dependency (`safe_hasattr` was
deleted from `testtools.helpers`). Disable tests until the next release.
Also point the origin to the github repo instead of pypy.
---
gnu/packages/python-xyz.scm | 13 ++++++++-----
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index c05502388e..3c9463b2c8 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -4163,14 +4163,17 @@ (define-public python-daemon
(version "2.3.0")
(source
(origin
- (method url-fetch)
- (uri (pypi-uri "python-daemon" version))
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://pagure.io/python-daemon.git";)
+ (commit (string-append "release/" version))))
+ (file-name (git-file-name name version))
(sha256
- (base32
- "1bxfn2bq56sd4w0nm9mqy8y0905m7fc8vmhnjxlrf49vcbqr7adx"))))
+ (base32 "1ysynb1m9vsww2nmhcypkk08xwifc3gw5yq10h1a1i11yn27w4y6"))))
(build-system python-build-system)
(arguments
- `(#:phases
+ `(#:tests? #false ; TODO reenable; tests got fixed after v2.3.0
+ #:phases
(modify-phases %standard-phases
(add-before 'check 'adjust-tests
(lambda _
--
2.34.0
--- End Message ---
--- Begin Message ---
|
Subject: |
Re: [bug#54232] [PATCH 1/2] gnu: python-daemon: Use the git repo as source instead of pypi. |
|
Date: |
Thu, 03 Mar 2022 15:46:15 +0100 |
|
User-agent: |
Evolution 3.38.3-1 |
Attila Lendvai schreef op do 03-03-2022 om 14:42 [+0000]:
> > Also, how does this address the test failure? The pypi and git are
> > at
> > the same version. Did upstream adjust the 'release/2.3.0' tag in
> > place
> > or something?
>
> sorry for not being clear enough! sending this patch was essentially
> a mistake: the tests do work fine.
>
> probably i have added the disabling of the test prior to the
> SUBSTITUTE* (that
> is basically a backport of the fix commit in upstream), and when i
> rebased some
> pending changes, then i mistakenly included the now irrelevant
> disabling.
>
> feel free to apply or reject this as you see fit. it's not important
> for me to build from git, even though i also find it better. probably
> the software heritage archives also work better with git.
They do support tarballs to some degree, and disarchive to some degree
compensates for mismatches. I don't know how well this works in
practice.
Anyway, I'm closing for now, but if it is discussed on guix-devel@ with
a positive conclusion, feel free to reopen.
Greetings,
Maxime.
signature.asc
Description: This is a digitally signed message part
--- End Message ---