bug#54180: closed ([PATCH 00/12] Home: Clarify and better test symlink-manager.scm)

[GNU bug Tracking System]

Your message dated Thu, 10 Mar 2022 11:45:45 +0100
with message-id <87y21ixezq.fsf@gnu.org>
and subject line Re: bug#54180: [PATCH 00/12] Home: Clarify and better test 
symlink-manager.scm
has caused the debbugs.gnu.org bug report #54180,
regarding [PATCH 00/12] Home: Clarify and better test symlink-manager.scm
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
54180: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=54180
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH 00/12] Home: Clarify and better test symlink-manager.scm
>
>
>
>
> Date: 
>
> Sun, 27 Feb 2022 14:40:06 +0100
>
>
>
>
> Hello Guix!
>
> This patch set aims to increase test coverage for ‘guix home reconfigure’,
> to make symlink-manager.scm IMO easier to follow, and to have it more
> closely follow the project’s conventions.
>
> Functionality is unchanged.
>
> Thoughts?
>
> Thanks,
> Ludo’.
>
> Ludovic Courtès (12):
>   home: symlink-manager: Clarify module imports.
>   home: symlink-manager: Move helper procedures as top-level defines.
>   home: symlink-manager: Use 'for-each' when used for effects.
>   home: symlink-manager: Use 'file-is-directory?'.
>   home: symlink-manager: Remove 'empty-directory?' and avoid TOCTTOU
>     race.
>   home: symlink-manager: Avoid extra 'lstat' call.
>   tests: Make sure 'guix home reconfigure' backs up files.
>   tests: Simplify use of 'local-file' in 'tests/guix-home.sh'.
>   tests: Check 'guix home reconfigure' for a second generation.
>   home: symlink-manager: 'cleanup-symlinks' uses 'file-system-fold'.
>   home: symlink-manager: 'create-symlinks' uses 'file-system-fold'.
>   home: symlink-manager: Rename "path" to "file" where appropriate.
>
>  gnu/home/services/symlink-manager.scm | 355 ++++++++++++--------------
>  tests/guix-home.sh                    |  44 +++-
>  2 files changed, 198 insertions(+), 201 deletions(-)
>
>
> base-commit: 33ce3f1c866231a3015411fdce18a3e72649e2f6
> -- 
> 2.34.0
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#54180: [PATCH 00/12] Home: Clarify and better test symlink-manager.scm
>
>
>
>
> Date: 
>
> Thu, 10 Mar 2022 11:45:45 +0100
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
>
>
>
>
> Hi!
>
> I went ahead and pushed this series:
>
>   2a55f99aff home: symlink-manager: Rename "path" to "file" where appropriate.
>   1fb6ef0473 home: symlink-manager: 'create-symlinks' uses 'file-system-fold'.
>   5fa188e92e home: symlink-manager: 'cleanup-symlinks' uses 'file-system-fold'.
>   5fabaf1128 tests: Check 'guix home reconfigure' for a second generation.
>   26e67e0280 tests: Simplify use of 'local-file' in 'tests/guix-home.sh'.
>   7b7e32d5ad tests: Make sure 'guix home reconfigure' backs up files.
>   a3a76a8384 home: symlink-manager: Avoid extra 'lstat' call.
>   a81bb1e4bb home: symlink-manager: Remove 'empty-directory?' and avoid TOCTTOU 
> race.
>   e1b38046a6 home: symlink-manager: Use 'file-is-directory?'.
>   cf803b71c7 home: symlink-manager: Use 'for-each' when used for effects.
>   7a8856f540 home: symlink-manager: Move helper procedures as top-level defines.
>   66bf60a4cd home: symlink-manager: Clarify module imports.
>
> Thanks Maxime for taking a look.
>
> Ludo’.
>
>
> --- End Message ---