bug#54368: closed ([PATCH 0/4] Add Btrfs RAID10 install tests.)

[GNU bug Tracking System]

Your message dated Sat, 19 Mar 2022 11:31:35 -0400
with message-id <87k0cq3qnc.fsf@gmail.com>
and subject line Re: bug#54368: [PATCH 0/4] Add Btrfs RAID10 install tests.
has caused the debbugs.gnu.org bug report #54368,
regarding [PATCH 0/4] Add Btrfs RAID10 install tests.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
54368: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=54368
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH 0/4] Add Btrfs RAID10 install tests.
>
>
>
>
> Date: 
>
> Sun, 13 Mar 2022 00:40:40 -0500
>
>
>
>
> Hello Guix!
>
> On the quest to get our Berlin CI machine rebooted on a Btrfs RAID10 array,
> these new system tests validate that software-wise, it's supposed to work.
>
> Thanks,
>
> Maxim Cournoyer (4):
>   tests: install: Adjust the timeouts on two failing tests.
>   tests: install: Streamline 'qemu-command/writable-image'.
>   tests: install: Enable the use of multiple disk devices for tests.
>   tests: install: Add two new Btrfs RAID10 install test.
>
>  gnu/tests/base.scm    |   6 +-
>  gnu/tests/install.scm | 382 +++++++++++++++++++++++++++---------------
>  2 files changed, 254 insertions(+), 134 deletions(-)
>
> -- 
> 2.34.0
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#54368: [PATCH 0/4] Add Btrfs RAID10 install tests.
>
>
>
>
> Date: 
>
> Sat, 19 Mar 2022 11:31:35 -0400
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
>
>
>
>
> Hi Mathieu,
>
> Mathieu Othacehe <othacehe@gnu.org> writes:
>
> > Hello Maxim,
> >
> > This looks great! I created a dedicated jobset here:
> > https://ci.guix.gnu.org/jobset/wip-btrfs-raid-tests to check everything
> > is still running fine.
> >
> >> +OS to install TARGET-OS.  Return the VM disk images of TARGET-SIZE bytes
> >> +containing the installed system.  Unless providing OS, the PACKAGES will be
> >> +added to the packages defined in INSTALLATION-OS (from (gnu system 
> >> install)).
> >> +NUMBER-OF-DISKS can be used to specify a number of disks different than one,
> >> +such as for RAID systems."
> >
> > I'm having troubles understanding the "Unless providing OS" part of the
> > sentence, but that's also because this mechanism of adding packages to
> > the default OS definition is tricky.
> >
> > Maybe we should augment the OS definition with those packages
> > unconditionally in the body of the "run-install" procedure.
>
> This is now done unconditionally.  I've also fixed the typo reported in
> another email on this thread, thank you!
>
> Retested with 'make check-system TESTS=btrfs-raid10-root-os' and pushed
> with commit b45a301618.
>
> Thanks for the review!
>
> Maxim
>
>
> --- End Message ---