emacs-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#54666: closed (Installation without non-root user accounts)


From: GNU bug Tracking System
Subject: bug#54666: closed (Installation without non-root user accounts)
Date: Wed, 06 Apr 2022 19:22:01 +0000

Your message dated Wed, 06 Apr 2022 21:20:58 +0200
with message-id <87y20iyq5h.fsf@gnu.org>
and subject line Re: bug#54666: Installation without non-root user accounts
has caused the debbugs.gnu.org bug report #54666,
regarding Installation without non-root user accounts
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
54666: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=54666
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
--- Begin Message --- Subject: Installation without non-root user accounts Date: Fri, 01 Apr 2022 12:31:34 +0200 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
Hello!

Using the installer, it’s possible to create a system config without any
non-root user accounts.  That’s a problem because then users end up
creating their account manually with ‘useradd’, which gets things wrong,
and things go awry.

To reproduce the issue, in the user page of the installer, add an
account for user “root”.  That’s enough to fool this check:

     (when (null? users)
       (run-error-page (G_ "Please create at least one user.")
                       (G_ "No user"))
       (run users))

This “root” account is then ignored:

  (define (users->configuration users)
    ;; …
    `((users (cons*
              ,@(filter-map (lambda (user)
                              ;; Do not emit a 'user-account' form for "root".
                              (and (not (string=? (user-name user) "root"))
                                   (user->sexp user)))
                            users)
              %base-user-accounts))))

… and that’s how you end up with a config without normal user accounts.

To address that, maybe ‘run-user-add-page’ should explicitly reject
“root”?

Ludo’.



--- End Message ---
--- Begin Message --- Subject: Re: bug#54666: Installation without non-root user accounts Date: Wed, 06 Apr 2022 21:20:58 +0200 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
Hey!

> Nitpick: you can omit ‘begin’ here.

Fixed it before pushing, thanks for having a look.

Mathieu


--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]