emacs-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#55086: closed (28.1; Improve doc of set-fontset-font)


From: GNU bug Tracking System
Subject: bug#55086: closed (28.1; Improve doc of set-fontset-font)
Date: Sun, 24 Apr 2022 06:58:01 +0000

Your message dated Sun, 24 Apr 2022 09:57:27 +0300
with message-id <83czh7nf3c.fsf@gnu.org>
and subject line Re: bug#55086: 28.1; Improve doc of set-fontset-font
has caused the debbugs.gnu.org bug report #55086,
regarding 28.1; Improve doc of set-fontset-font
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
55086: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=55086
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
--- Begin Message --- Subject: 28.1; Improve doc of set-fontset-font Date: Sat, 23 Apr 2022 17:51:21 -0400
The eldoc string for set-fontset-font in Emacs 28 is

    (NAME TARGET FONT-SPEC &optional FRAME ADD)

I found NAME and TARGET to be unhelpfully generic.  The
docstring does say that name is the name of a fontset and
that TARGET is about characters.

The elisp manual names the params as:

    Function: set-fontset-font name character font-spec &optional frame add

character is an improvement but it should be plural.

I think they should be the same in both places and
this would be clearer:

    (FONTSET CHARACTERS FONT-SPEC &optional FRAME ADD)

Howard



--- End Message ---
--- Begin Message --- Subject: Re: bug#55086: 28.1; Improve doc of set-fontset-font Date: Sun, 24 Apr 2022 09:57:27 +0300
> From: Howard Melman <hmelman@gmail.com>
> Date: Sat, 23 Apr 2022 17:51:21 -0400
> 
> The eldoc string for set-fontset-font in Emacs 28 is
> 
>     (NAME TARGET FONT-SPEC &optional FRAME ADD)
> 
> I found NAME and TARGET to be unhelpfully generic.  The
> docstring does say that name is the name of a fontset and
> that TARGET is about characters.
> 
> The elisp manual names the params as:
> 
>     Function: set-fontset-font name character font-spec &optional frame add
> 
> character is an improvement but it should be plural.
> 
> I think they should be the same in both places and
> this would be clearer:
> 
>     (FONTSET CHARACTERS FONT-SPEC &optional FRAME ADD)

Thanks, done.


--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]