--- Begin Message ---
|
Subject: |
[PATCH] Upgrade nyacc to 1.07.0 |
|
Date: |
Thu, 2 Jun 2022 05:14:53 -0700 |
Control: tags -1 + patch
Hi,
For my work in making PAM configurable in Guile, I rely on the foreign
function interface (FFI). The automatic generation of that interface
requires the compile-ffi script in nyacc. Unfortunately, the highest
version we ship suffers from a bug that prevents the script from
running on the pam_client.h header in linux-pam. This patch upgrades
nyacc to the version Matt Wette released after committing the fix.
The changes are further documented in the commit message.
I am new to Guix and already use the new version of linux-pam locally
(via Guix System) but I was unable to test the patch according to the
requirements and recommendations listed for this submission. [1]
This email was sent to -devel in lieu of -mentors, which does not
exist. Any guidance is much appreciated. Thanks for taking a look!
KInd regards
Felix Lechner
[1] https://guix.gnu.org/en/manual/devel/en/html_node/Submitting-Patches.html
0001-Upgrade-nyacc-to-1.07.0.patch
Description: Source code patch
--- End Message ---
--- Begin Message ---
|
Subject: |
Re: bug#55763: [PATCH] Upgrade nyacc to 1.07.0 |
|
Date: |
Tue, 07 Jun 2022 18:22:51 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) |
Hello,
Felix Lechner <felix.lechner@gmail.com> skribis:
> For my work in making PAM configurable in Guile, I rely on the foreign
> function interface (FFI). The automatic generation of that interface
> requires the compile-ffi script in nyacc. Unfortunately, the highest
> version we ship suffers from a bug that prevents the script from
> running on the pam_client.h header in linux-pam. This patch upgrades
> nyacc to the version Matt Wette released after committing the fix.
>
> The changes are further documented in the commit message.
>
> I am new to Guix and already use the new version of linux-pam locally
> (via Guix System) but I was unable to test the patch according to the
> requirements and recommendations listed for this submission. [1]
>
> This email was sent to -devel in lieu of -mentors, which does not
> exist. Any guidance is much appreciated. Thanks for taking a look!
The patch is perfect; I only adjusted the commit log so that it follows
the ChangeLog convention, as Josselin pointed out:
https://guix.gnu.org/manual/devel/en/html_node/Submitting-Patches.html
I also check that dependents, as reported by ‘guix refresh -l nyacc’,
all build fine with the new version.
Thanks,
Ludo’.
PS: guix-mentors now exists!
--- End Message ---