--- Begin Message ---
|
Subject: |
ZRAM default priority wrong |
|
Date: |
Thu, 07 Apr 2022 22:27:23 -0400 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
I have a swap file and zram configured without specifying
priority. The swap file was assigned -2, and zram -3, with the
effect that zram was never used. I had to manually change the zram
priority to something higher that that of the swap file.
The manual wrongly claims that the default priority for zram is
-1. The same paragraph of the manual also says:
‘swapon’ accepts values between -1 and 32767, with higher
values indicating higher priority.
which makes the -2 priority of the swap file look suspect (though
it seems to work).
--- End Message ---
--- Begin Message ---
|
Subject: |
Re: bug#54783: ZRAM default priority wrong |
|
Date: |
Sat, 11 Jun 2022 01:56:38 -0400 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) |
Hi Josselin,
[...]
>
> On the Guix side of things, we should really be using the same interface
> as swap-space, as I think the distinction between #f and 0 to 32767 is
> clearer. I'll send some patches that adress this soon, along with the
> zram-service-type documentation.
I've made this smallish change:
--8<---------------cut here---------------start------------->8---
modified gnu/services/linux.scm
@@ -296,14 +296,12 @@ (define (zram-device-configuration->udev-string config)
"")
"RUN+=\"/run/current-system/profile/sbin/mkswap /dev/zram0\" "
"RUN+=\"/run/current-system/profile/sbin/swapon "
- ;; XXX: The field is delayed while the deprecation warning remains in
- ;; place, so we can't use match to fetch it (it would give a promise)
- (if (zram-device-configuration-priority config)
- (string-append "--priority "
- (number->string
- (zram-device-configuration-priority config))
- " ")
- "")
+ ;; TODO: Revert to simply use 'priority' after removing the deprecation
+ ;; warning and the delayed property of the field.
+ (let ((priority* (force priority)))
+ (if priority*
+ (format #f "--priority ~a " priority*)
+ ""))
"/dev/zram0\"\n"))))
(define %zram-device-config
--8<---------------cut here---------------end--------------->8---
Because the TODO comments seems more actionable for my future self, and
pushed as a99015c878.
Thanks Stefan for reporting the issue and for Josselin for fixing it!
Closing.
Maxim
--- End Message ---