emacs-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#54796: closed ([PATCH v3 00/22] Add importer for hex.pm and rebar3 b


From: GNU bug Tracking System
Subject: bug#54796: closed ([PATCH v3 00/22] Add importer for hex.pm and rebar3 build-system for Erlang)
Date: Wed, 15 Jun 2022 09:21:02 +0000

Your message dated Wed, 15 Jun 2022 11:20:49 +0200
with message-id <427ac7c5-a3a2-b892-315f-4a66f31d4da0@crazy-compilers.com>
and subject line Re: [PATCH v4 00/22] Add importer for hex.pm and rebar3 
build-system for Erlang
has caused the debbugs.gnu.org bug report #54796,
regarding [PATCH v3 00/22] Add importer for hex.pm and rebar3 build-system for 
Erlang
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
54796: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=54796
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
--- Begin Message --- Subject: [PATCH v3 00/22] Add importer for hex.pm and rebar3 build-system for Erlang Date: Fri, 8 Apr 2022 19:01:55 +0200
Hi,

this is an updated version of #42180 and #51061 (both are closed
already). Notable changes are:

* the „extracting downloader“ and „hexpm-fetch” are gone

* documentation added for both the importer and the rebar3-build-system

* tests added for the importer

Some remarks on the patches:

* First patch adds a file guix/hexpm-download.scm, containing
  definitions for the hex.pm repository. These are combined in
  this module here since different build-systems (will) use it.

* The importer tries to detect the build system to be used. For Elexir
  packages it creates package definitions using the “mix-build-system‘. This I
  will add later (WIP).

* Next there patches provide the packages required rebar3, rebar3 itself and
  some plugins for rebar3.

Open question:

* Shall the build system actually be called „rebar*3*“ or just „rebar“? There
  is also a build-tool „rebar2“, which is obsoltete and not supported by this
  build-system. Anyhow, somewhen in the future there might be some „rebar4“,
  which we might be able to cover with the same build-system. WDYT?


Hartmut Goebel (22):
  import: Add hex.pm importer.
  gnu: Add erlang-cf.
  gnu: Add erlang-certifi.
  gnu: Add erlang-erlware-commons.
  gnu: Add erlang-cth-readable.
  gnu: Add erlang-bbmustache.
  gnu: Add erlang-getopt.
  gnu: Add erlang-eunit-formatters.
  gnu: Add erlang-providers.
  gnu: Add erlang-parse-trans.
  gnu: Add erlang-hex-core.
  gnu: Add erlang-ssl-verify-fun.
  gnu: Add erlang-relx.
  gnu: Add erlang-edown.
  gnu: Add erlang-jsone.
  gnu: Add erlang-proper.
  gnu: Add erlang-covertool.
  gnu: Add rebar3.
  gnu: Add rebar3-raw-deps.
  gnu: Add rebar3-git-vsn.
  gnu: Add rebar3-proper.
  build-system: Add 'rebar3-build-system'.

 Makefile.am                        |   6 +
 doc/guix.texi                      |  70 ++++-
 gnu/packages/erlang.scm            | 488 +++++++++++++++++++++++++++++
 guix/build-system/rebar3.scm       | 143 +++++++++
 guix/build/rebar3-build-system.scm | 147 +++++++++
 guix/hexpm-download.scm            |  40 +++
 guix/import/hexpm.scm              | 347 ++++++++++++++++++++
 guix/scripts/import.scm            |   2 +-
 guix/scripts/import/hexpm.scm      | 109 +++++++
 po/guix/POTFILES.in                |   1 +
 tests/hexpm.scm                    | 257 +++++++++++++++
 11 files changed, 1608 insertions(+), 2 deletions(-)
 create mode 100644 guix/build-system/rebar3.scm
 create mode 100644 guix/build/rebar3-build-system.scm
 create mode 100644 guix/hexpm-download.scm
 create mode 100644 guix/import/hexpm.scm
 create mode 100644 guix/scripts/import/hexpm.scm
 create mode 100644 tests/hexpm.scm

-- 
2.30.2




--- End Message ---
--- Begin Message --- Subject: Re: [PATCH v4 00/22] Add importer for hex.pm and rebar3 build-system for Erlang Date: Wed, 15 Jun 2022 11:20:49 +0200 User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Many thanks for the review. Finally I finished this patch series and pushed as 9cccf6490d98bd40ea1eb9e84ecf4a2b32614107

Notable changes compared to last review comments:

* removed guix extracting-download - which was an left-over

* build-system is now named rebar (without '3')

* fixed some minor lint-errors

I also validated that all packages are up to date.

--
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel@crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |



--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]