bug#58963: closed ([PATCH] gnu: python-funcparserlib: Enable tests.)

[GNU bug Tracking System]

Your message dated Sat, 05 Nov 2022 12:00:29 +0100
with message-id <874jvdis2k.fsf@cbaines.net>
and subject line Re: [bug#58963] [PATCH] gnu: python-funcparserlib: Enable 
tests.
has caused the debbugs.gnu.org bug report #58963,
regarding [PATCH] gnu: python-funcparserlib: Enable tests.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
58963: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=58963
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] gnu: python-funcparserlib: Enable tests.
>
>
>
>
> Date: 
>
> Wed,  2 Nov 2022 02:03:46 -0500
>
>
>
>
> * gnu/packages/python-xyz.scm (python-funcparserlib): Enable tests.
> [origin]: Use GitHub since it includes the tests unlike PyPi.
> [build-system]: Use pyproject-build-system.
> [arguments]: Run tests.
> [native-inputs]: Add python-poetry-core.
> ---
>  gnu/packages/python-xyz.scm | 25 ++++++++++++++++++-------
>  1 file changed, 18 insertions(+), 7 deletions(-)
>
> diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
> index 1c2f9d7b73..eb5b74c993 100644
> --- a/gnu/packages/python-xyz.scm
> +++ b/gnu/packages/python-xyz.scm
> @@ -25303,14 +25303,25 @@ (define-public python-funcparserlib
>      (name "python-funcparserlib")
>      (version "1.0.0")
>      (source
> -     (origin
> -       (method url-fetch)
> -       (uri (pypi-uri "funcparserlib" version))
> -       (sha256
> -        (base32 "0swbqf53x7lfnczvi566s1g3nkf5mfrxz7sbpyymricz57a3vlvx"))))
> -    (build-system python-build-system)
> +      (origin
> +        ;; Source tarball on PyPi lacks tests.
> +        (method git-fetch)
> +        (uri (git-reference
> +              (url "https://github.com/vlasovskikh/funcparserlib";)
> +              (commit version)))
> +        (file-name (git-file-name name version))
> +        (sha256
> +         (base32 "00pswdys5c4hpqpvfcy5zqv30gyjvjvagi12811jizw57hxrm1cs"))))
> +    (build-system pyproject-build-system)
>      (arguments
> -     `(#:tests? #f))              ; no tests in PyPI and no setup.py in GitHub
> +     '(#:phases
> +       (modify-phases %standard-phases
> +         (replace 'check
> +           (lambda* (#:key tests? #:allow-other-keys)
> +             (when tests?
> +               (invoke "python" "-m" "unittest" "discover" "-v")))))))
> +    ;; ModuleNotFoundError: No module named 'poetry'
> +    (native-inputs (list python-poetry-core))
>      (home-page "https://github.com/vlasovskikh/funcparserlib";)
>      (synopsis
>       "Recursive descent parsing library based on functional combinators")
> -- 
> 2.38.1
>
>
>
>
> --- End Message ---

--- Begin Message --- Subject: Re: [bug#58963] [PATCH] gnu: python-funcparserlib: Enable tests. Date: Sat, 05 Nov 2022 12:00:29 +0100 User-agent: mu4e 1.8.9; emacs 28.1

jgart via Guix-patches via <guix-patches@gnu.org> writes:

> * gnu/packages/python-xyz.scm (python-funcparserlib): Enable tests.
> [origin]: Use GitHub since it includes the tests unlike PyPi.
> [build-system]: Use pyproject-build-system.
> [arguments]: Run tests.
> [native-inputs]: Add python-poetry-core.
> ---
>  gnu/packages/python-xyz.scm | 25 ++++++++++++++++++-------
>  1 file changed, 18 insertions(+), 7 deletions(-)

Looks good to me, I've pushed to master as
f91713e71b6bc1222c8f5b218dede3dc7e670a3c.

Chris

signature.asc
Description: PGP signature

--- End Message ---