bug#58002: closed (29.1: Sokoban: obsoletion warnings in gamegrid)

[GNU bug Tracking System]

Your message dated Sun, 13 Nov 2022 05:59:01 -0800
with message-id 
<CADwFkm=xyBqPqw3x4wKTe010=DpHrOLZjsaVdRri=BemzkgeCQ@mail.gmail.com>
and subject line Re: bug#58002: 29.1: Sokoban: obsoletion warnings in gamegrid
has caused the debbugs.gnu.org bug report #58002,
regarding 29.1: Sokoban: obsoletion warnings in gamegrid
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
58002: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=58002
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems

--- Begin Message --- Subject: 29.1: Sokoban: obsoletion warnings in gamegrid Date: Thu, 22 Sep 2022 12:06:27 +0200

On Emacs master, starting Sokoban (from GNU ELPA) results in several warnings:

> Warning (gamegrid): Using obsolete XEmacs style "glyph"; convert to an Emacs 
> image-spec instead

which apparently is from

> (defvar sokoban-target-options
>   `(((glyph
>       [xpm :data ,sokoban-target-xpm])
[...]

where (after some digging) it seems that the vector needs to be

      ((:type xpm :data ,sokoban-target-xpm :ascent center)))

somewhat non-intuitively, because of the slightly alarming line

>          (find-image data)) ;untested!

in gamegrid.el. Suggested patch attached.
Is this all correct and as desired? Does it break anything when using old Emacs 
versions?

sokoban-warning.diff
Description: Binary data

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#58002: 29.1: Sokoban: obsoletion warnings in gamegrid
>
>
>
>
> Date: 
>
> Sun, 13 Nov 2022 05:59:01 -0800
>
>
>
>
> Dieter Deyke <dieter.deyke@gmail.com> writes:
>
> > Yes, the patch was installed, the warnings are gone, everything is fine
> > now. Please close the bug.
>
> Thanks, done.
>
>
> --- End Message ---