bug#61360: closed ([PATCH] gnu: gimp: Don't retain reference on GCC.)

[GNU bug Tracking System]

Your message dated Thu, 02 Mar 2023 11:44:39 +0800
with message-id <87fsanq0k8.fsf_-_@envs.net>
and subject line Re: bug#61360: [PATCH] gnu: gimp: Don't retain reference on 
GCC.
has caused the debbugs.gnu.org bug report #61360,
regarding [PATCH] gnu: gimp: Don't retain reference on GCC.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
61360: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=61360
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] gnu: gimp: Don't retain reference on GCC.
>
>
>
>
> Date: 
>
> Wed,  8 Feb 2023 15:09:30 +0800
>
>
>
>
> From: 宋文武 <iyzsong@member.fsf.org>
>
> Partly fixes <https://issues.guix.gnu.org/57677>.
>
> * gnu/packages/gimp.scm (gimp)[arguments]: Add #:modules and #:phases.
> ---
>  gnu/packages/gimp.scm | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
>
> diff --git a/gnu/packages/gimp.scm b/gnu/packages/gimp.scm
> index beb43f0ae2..69281f98e9 100644
> --- a/gnu/packages/gimp.scm
> +++ b/gnu/packages/gimp.scm
> @@ -302,6 +302,19 @@ (define-public gimp
>                 "doc"))                  ; 9 MiB of gtk-doc HTML
>      (arguments
>       (list
> +      #:modules `((ice-9 popen)
> +                  (ice-9 rdelim)
> +                  ,@%gnu-build-system-modules)
> +      #:phases
> +      #~(modify-phases %standard-phases
> +          (add-after 'unpack 'remove-gcc-reference
> +            ;; Avoid reference to GCC.
> +            (lambda _
> +              (let* ((port (open-input-pipe "gcc -v 2>&1 | tail -n 1"))
> +                     (cc-version (read-line port)))
> +                (close-pipe port)
> +                (substitute* "app/gimp-version.c"
> +                  (("CC_VERSION") (string-append "\"" cc-version "\"")))))))
>        #:configure-flags
>        #~(list (string-append "--with-html-dir=" #$output "/share/gtk-doc/html")
>  
> -- 
> 2.39.1
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#61360: [PATCH] gnu: gimp: Don't retain reference on GCC.
>
>
>
>
> Date: 
>
> Thu, 02 Mar 2023 11:44:39 +0800
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
>
>
>
>
> Christopher Baines <mail@cbaines.net> writes:
>
> > iyzsong--- via Guix-patches via <guix-patches@gnu.org> writes:
> >
> >> From: 宋文武 <iyzsong@member.fsf.org>
> >>
> >> Partly fixes <https://issues.guix.gnu.org/57677>.
> >>
> >> * gnu/packages/gimp.scm (gimp)[arguments]: Add #:modules and #:phases.
> >> ---
> >>  gnu/packages/gimp.scm | 13 +++++++++++++
> >>  1 file changed, 13 insertions(+)
> >
> > I don't quite get what's going on here, but it seems good to push.
> >
>
> Pushed, thank you!
>
>
> --- End Message ---