bug#63325: closed ([PATCH] gnu: vulkan-loader: Only run tests on x86.)

[GNU bug Tracking System]

Your message dated Mon, 15 May 2023 22:04:37 +0300
with message-id <ZGKCRWR9FTnkoy8n@3900XT>
and subject line Re: [bug#63325] [PATCH] gnu: vulkan-loader: Only run tests on 
x86.
has caused the debbugs.gnu.org bug report #63325,
regarding [PATCH] gnu: vulkan-loader: Only run tests on x86.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
63325: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=63325
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] gnu: vulkan-loader: Only run tests on x86.
>
>
>
>
> Date: 
>
> Sat,  6 May 2023 10:04:18 +0100
>
>
>
>
> * gnu/packages/vulkan.scm (vulkan-loader)[arguments]: Only run tests on x86.
> ---
>  gnu/packages/vulkan.scm | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/gnu/packages/vulkan.scm b/gnu/packages/vulkan.scm
> index b0d968938b..f03c3dbc6f 100644
> --- a/gnu/packages/vulkan.scm
> +++ b/gnu/packages/vulkan.scm
> @@ -228,8 +228,10 @@ (define-public vulkan-loader
>      (build-system cmake-build-system)
>      (arguments
>       (list
> -      #:tests? (not (or (%current-target-system)
> -                        (target-riscv64?)))
> +      ;; TODO: Some tests seem to assume running on x86,
> +      ;; e.g. TryLoadWrongBinaries
> +      #:tests? (and (target-x86?)
> +                    (not (%current-target-system)))
>        #:configure-flags
>        #~(list (string-append "-DVULKAN_HEADERS_INSTALL_DIR="
>                               (dirname (dirname
>
> base-commit: 64086a4fa449a9f6d2f835fcdf5498222b309e3a
> -- 
> 2.39.1
>
>
>
>
> --- End Message ---

--- Begin Message --- Subject: Re: [bug#63325] [PATCH] gnu: vulkan-loader: Only run tests on x86. Date: Mon, 15 May 2023 22:04:37 +0300

On Thu, May 11, 2023 at 02:59:57PM +0200, Simon Tournier wrote:
> Hi,
> 
> On mar., 09 mai 2023 at 16:53, Simon South <simon@simonsouth.net> wrote:
> 
> > https://issues.guix.gnu.org/63400
> 
> I am in favor to close this submission and consider #63400.  Chris,
> WDYT?

Having come to basically the same patch (sorry Chris!) and having pushed
it, I'm going to close this patch and we can continue in 63400, which so
far has us skipping enough tests to pass on aarch64 but still fail on
other architectures.

-- 
Efraim Flashner   <efraim@flashner.co.il>   רנשלפ םירפא
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

signature.asc
Description: PGP signature

--- End Message ---