bug#63411: closed (29.0.90; pcomplete/systemctl cannot complete units for old versions of systemd)

[GNU bug Tracking System]

Your message dated Sat, 20 May 2023 18:02:49 +0300
with message-id <838rdjrqp2.fsf@gnu.org>
and subject line Re: bug#63411: [PATCH] pcomplete/systemctl cannot complete 
units for old versions of systemd
has caused the debbugs.gnu.org bug report #63411,
regarding 29.0.90; pcomplete/systemctl cannot complete units for old versions 
of systemd
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
63411: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=63411
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> 29.0.90; pcomplete/systemctl cannot complete units for old versions of systemd
>
>
>
>
> Date: 
>
> Wed, 10 May 2023 17:47:09 +0800
>
>
>
>
> Hi,
>
> It is very convenient that Emacs 29 supports eshell completion for
> systemctl, but I find units cannot be completed on Ubuntu 20.04 LTS:
>
> 1. emacs -Q
> 2. M-x eshell
> 3. type "systemctl stop ", and press TAB
>
> There is no completion for units.
>
> The reason is that 'pcmpl-linux--systemd-units' uses a new option
> '--legend=no' that is introduced since Feb 18, 2021[1], and the option
> cannot be recognized by systemd v245 on my system. Since the old
> option '--no-legend' is still kept for compatibility[2], I suggest we
> can just replace '--legend=no' with '--no-legend' to make systemctl
> completion works for old systems.
>
> [1] https://github.com/systemd/systemd/pull/18596
> [2] https://github.com/systemd/systemd/blob/main/src/systemctl/systemctl.c#L485
>
> Best,
> Liu Hui
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#63411: [PATCH] pcomplete/systemctl cannot complete units for old versions of systemd
>
>
>
>
> Date: 
>
> Sat, 20 May 2023 18:02:49 +0300
>
>
>
>
> > Date: Thu, 18 May 2023 11:57:46 -0700
> > Cc: 63411@debbugs.gnu.org
> > From: Jim Porter <jporterbugs@gmail.com>
> > 
> > On 5/18/2023 7:16 AM, Eli Zaretskii wrote:
> > >> From: Liu Hui <liuhui1610@gmail.com>
> > >> Date: Thu, 18 May 2023 21:29:46 +0800
> > >> Cc: 63411@debbugs.gnu.org
> > >>
> > >> --no-legend is indeed superseded by --legend=yes/no in systemd v248+,
> > >> but it is not deprecated. It is kept for compatibility and is totally
> > >> equivalent to --legend=no, and doesn't produce any warning message. I
> > >> have tested with systemctl v249 on Ubuntu 22.04 and the outputs are
> > >> same. In fact, the point of the new option is it allows to display
> > >> legends by --legend=yes in spite of other options such as --quiet,
> > >> which is explained in https://github.com/systemd/systemd/pull/18596.
> > > 
> > > Thanks, I think I will wait for a few days to let others chime in.
> > 
> > I stumbled on this too, and was about to post a patch before I noticed 
> > this bug, so I support this change.
>
> Thanks, installed on the emacs-29 branch, and closing the bug.
>
>
> --- End Message ---