bug#63499: closed ([PATCH gnome-team 0/3] To GTK and beyond)

[GNU bug Tracking System]

Your message dated Sat, 27 May 2023 16:25:44 +0200
with message-id <6eb778c87e3c661c50a289f6a05cbbfe02801e65.camel@gmail.com>
and subject line Re: [bug#63499] [PATCH gnome-team 3/3] gnu: gtksourceview: Fix 
build.
has caused the debbugs.gnu.org bug report #63499,
regarding [PATCH gnome-team 0/3] To GTK and beyond
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
63499: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=63499
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH gnome-team 0/3] To GTK and beyond
>
>
>
>
> Date: 
>
> Sun, 14 May 2023 12:35:46 +0200
>
>
>
>
> Hi Guix,
>
> with this series, GTK 4.10, Gtksourceview and everything up to WebkitGTK ought
> to build fine.  This means we can finally start working on the actual gnome-*
> packages soon :)
>
> Cheers
>
> Liliana Marie Prikler (3):
>   gnu: gst-plugins-base: Fix build.
>   gnu: gtk: Update to 4.10.3.
>   gnu: gtksourceview: Fix build.
>
>  gnu/local.mk                                  |  1 +
>  gnu/packages/gstreamer.scm                    |  3 ++-
>  gnu/packages/gtk.scm                          | 14 +++++++++---
>  .../gst-plugins-base-fix-broken-test.patch    | 22 +++++++++++++++++++
>  4 files changed, 36 insertions(+), 4 deletions(-)
>  create mode 100644 gnu/packages/patches/gst-plugins-base-fix-broken-test.patch
>
>
> base-commit: 09dd600159801b3b8fd6b95bf69e648f9e37d959
> -- 
> 2.39.2
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [bug#63499] [PATCH gnome-team 3/3] gnu: gtksourceview: Fix build.
>
>
>
>
> Date: 
>
> Sat, 27 May 2023 16:25:44 +0200
>
>
>
>
> User-agent: 
>
> Evolution 3.46.4 
>
>
>
>
> Am Montag, dem 15.05.2023 um 15:44 -0400 schrieb Maxim Cournoyer:
> > Hi,
> > 
> > Liliana Marie Prikler <liliana.prikler@gmail.com> writes:
> > 
> > > Am Montag, dem 15.05.2023 um 09:49 -0400 schrieb Maxim Cournoyer:
> > > > Hello,
> > > > 
> > > > Liliana Marie Prikler <liliana.prikler@gmail.com> writes:
> > > > 
> > > > > * gnu/packages/gtk.scm (gtksourceview)[#:phases]<pre-check>:
> > > > > Set
> > > > > “GDK_BACKEND”
> > > > > and “GTK_A11Y”.
> > > > > ---
> > > > >  gnu/packages/gtk.scm | 3 +++
> > > > >  1 file changed, 3 insertions(+)
> > > > > 
> > > > > diff --git a/gnu/packages/gtk.scm b/gnu/packages/gtk.scm
> > > > > index de45eb3870..7d76610293 100644
> > > > > --- a/gnu/packages/gtk.scm
> > > > > +++ b/gnu/packages/gtk.scm
> > > > > @@ -616,6 +616,9 @@ (define-public gtksourceview
> > > > >                 ;; Tests require a running X server.
> > > > >                 (system (string-append Xvfb " :1 &"))
> > > > >                 (setenv "DISPLAY" ":1")
> > > > > +               ;; For GTK
> > > > 
> > > > Nitpick: Add a full stop (period) for standalone comments. 
> > > > Perhaps
> > > > expound how these environment variables are useful to set ('For
> > > > GTK'
> > > > leaves me wondering, as 'gtksourceview' already seems GTK-
> > > > focused).
> > > Full disclosure, I don't quite understand what's wrong here myself,
> > > but
> > > with the upgrade to GTK 4.10, tests fail
> > > - due to GDK_BACKEND not being said for ??? reason
> > > - due to GTK_A11Y because GTK tries to spawn dbus and fails to
> > > connect.
> > > 
> > > > 
> > > If there's a better wording for that, I'm all ears :)
> > 
> > Perhaps above setenv "GTK_BACKEND" mention "XXX: To avoid failures in
> > tests." and then above GTK_A11Y mention "Otherwise, GTK tries to
> > spawn D-Bus and fails to connect."
> > 
> > This captures everything you know; I think it's an improvement.
> Reworded a little and pushed with GStreamer 1.22.3.
>
> Cheers
>
>
> --- End Message ---