bug#68346: closed ([PATCH 0/2] semver aware cargo refresh)

[GNU bug Tracking System]

Your message dated Tue, 16 Jan 2024 14:26:21 +0200
with message-id <ZaZ17dDKOuBLQJup@3900XT>
and subject line Re: [PATCH 0/2] semver aware cargo refresh
has caused the debbugs.gnu.org bug report #68346,
regarding [PATCH 0/2] semver aware cargo refresh
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
68346: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=68346
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH 0/2] semver aware cargo refresh
>
>
>
>
> Date: 
>
> Tue,  9 Jan 2024 15:05:45 +0200
>
>
>
>
> These patches make 'guix refresh' take into account the semver of the
> crate and only suggest upgrading to one which still matches the semver
> constraints and isn't yanked.  Then I went and used the functions to
> factor out some of the other code.
>
> Efraim Flashner (2):
>   import: crate: Update to latest semver version.
>   import: crate: Simplify find-crate-version.
>
>  guix/import/crate.scm | 59 +++++++++++++++++++++++++++----------------
>  1 file changed, 37 insertions(+), 22 deletions(-)
>
>
> base-commit: b26926189e5bf253093050f9a73f2d9d7555cc3e
> -- 
> Efraim Flashner   <efraim@flashner.co.il>   רנשלפ םירפא
> GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
> Confidentiality cannot be guaranteed on emails sent or received unencrypted
>
>
>
>
> --- End Message ---

--- Begin Message --- Subject: Re: [PATCH 0/2] semver aware cargo refresh Date: Tue, 16 Jan 2024 14:26:21 +0200

On Sun, Jan 14, 2024 at 12:54:27PM +0000, David Elsing wrote:
> Hello,
> 
> Efraim Flashner <efraim@flashner.co.il> writes:
> > These patches make 'guix refresh' take into account the semver of the
> > crate and only suggest upgrading to one which still matches the semver
> > constraints and isn't yanked.  Then I went and used the functions to
> > factor out some of the other code.
> 
> thanks for cleaning this up a bit! I tested your patches and only found
> the (minor) issue that an exception is thrown instead of returning #f if
> there is no non-yanked package available. The minimum element can also
> be found without sorting, so I would suggest something like the
> following changes:

I still think I like sort better, but it definitely doesn't do as good a
job of taking care of the #f case as your code does.  I incorporated
your changes and pushed them.

-- 
Efraim Flashner   <efraim@flashner.co.il>   רנשלפ םירפא
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

signature.asc
Description: PGP signature

--- End Message ---