bug#48849: closed ([PATCH core-updates]: Add #:sh argument to wrap-qt-program)

[GNU bug Tracking System]

Your message dated Mon, 22 Jan 2024 00:12:36 -0500
with message-id <878r4i3q9n.fsf@gmail.com>
and subject line Re: bug#48849: [PATCH core-updates]: Add #:sh argument to 
wrap-qt-program
has caused the debbugs.gnu.org bug report #48849,
regarding [PATCH core-updates]: Add #:sh argument to wrap-qt-program
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
48849: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=48849
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems

--- Begin Message --- Subject: [PATCH core-updates]: Add #:sh argument to wrap-qt-program Date: Sat, 05 Jun 2021 13:49:23 +0200 User-agent: Evolution 3.34.2

Hi guix,

This patch series adds a #:sh keyword argument to wrap-qt-program
and adjusts callers to set this keyword argument appropriately.

Setting this argument appropriately is required for cross-compilation.
Otherwise, a bash for SYSTEM (as in --system=..) is used instead
of a bash for TARGET (as in --target=...).

I didn't test building some qt programs with this patch series yet,
as I'm currently waiting on the substitute servers to catch up
with recent changed to core-updates (to avoid building a tower
of rusts). I'll do that later.

Greetings,
Maxime

0001-qt-utils-Allow-overriding-the-shell-interpreter-in-w.patch
Description: Text Data

0002-gnu-qbittorrent-Set-sh-argument-of-wrap-qt-program.patch
Description: Text Data

0003-gnu-electron-cash-Set-sh-argument-of-wrap-qt-program.patch
Description: Text Data

0004-gnu-qgis-Set-sh-argument-of-wrap-qt-program.patch
Description: Text Data

0005-gnu-keepassxc-Set-sh-argument-of-wrap-qt-program.patch
Description: Text Data

0006-gnu-qtpass-Set-sh-argument-of-wrap-qt-program.patch
Description: Text Data

0007-gnu-openshot-Set-sh-argument-of-wrap-qt-program.patch
Description: Text Data

0008-gnu-kristall-Set-sh-argument-of-wrap-qt-program.patch
Description: Text Data

signature.asc
Description: This is a digitally signed message part

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#48849: [PATCH core-updates]: Add #:sh argument to wrap-qt-program
>
>
>
>
> Date: 
>
> Mon, 22 Jan 2024 00:12:36 -0500
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13)
>
>
>
>
> Hi again,
>
> Maxime Devos <maximedevos@telenet.be> writes:
>
> > Hi guix,
> >
> > This patch series adds a #:sh keyword argument to wrap-qt-program
> > and adjusts callers to set this keyword argument appropriately.
> >
> > Setting this argument appropriately is required for cross-compilation.
> > Otherwise, a bash for SYSTEM (as in --system=..) is used instead
> > of a bash for TARGET (as in --target=...).
> >
> > I didn't test building some qt programs with this patch series yet,
> > as I'm currently waiting on the substitute servers to catch up
> > with recent changed to core-updates (to avoid building a tower
> > of rusts). I'll do that later.
> >
> > Greetings,
> > Maxime
> >
> > From 27d42f25f54b16f382e18b9ef0fb202fb00da90d Mon Sep 17 00:00:00 2001
> > From: Maxime Devos <maximedevos@telenet.be>
> > Date: Sat, 5 Jun 2021 11:02:16 +0200
> > Subject: [PATCH 1/8] qt-utils: Allow overriding the shell interpreter in
> >  'wrap-qt-program'.
> >
> > * guix/build/qt-utils.scm (wrap-qt-program): Introduce a #:sh keyword
> >   argument and pass it to 'wrap-program'.
>
> I see this patch was already merged by Mathieu in
> 77b98bf1874aac8ed447e9f0b0ee0865a1d652ba; thus, I'm closing this ticket.
>
> Thank you!
>
> -- 
> Maxim
>
>
> --- End Message ---