bug#61946: closed ([PATCH 0/6] gnu: golang: Add minify)

[GNU bug Tracking System]

Your message dated Tue, 30 Jan 2024 23:17:29 +0000
with message-id <87v87as96e.fsf@gmail.com>
and subject line [PATCH 0/6] gnu: golang: Add minify
has caused the debbugs.gnu.org bug report #61946,
regarding [PATCH 0/6] gnu: golang: Add minify
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
61946: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=61946
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH 0/6] gnu: golang: Add minify
>
>
>
>
> Date: 
>
> Fri,  3 Mar 2023 23:55:27 +0100
>
>
>
>
> Hello there!
>
> This is a patch series to add the golang minify package, a golang
> dependency needed for sourcehut.
>
> Thomas Ieong (6):
>   gnu: Add go-github-com-djherbis-atime.
>   gnu: Add go-github-com-matryer-try.
>   gnu: Add go-github-com-tdewolff-parse-v2.
>   gnu: Add go-github-com-tdewolff-test.
>   gnu: Add go-github-com-tdewolff-minify-v2.
>   gnu: Add minify.
>
>  gnu/packages/golang.scm | 143 ++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 143 insertions(+)
>
>
> base-commit: 73cb232442a50aa00104ad739db93f44df9de073
> -- 
> 2.39.1
>
>
>
>
> --- End Message ---

--- Begin Message --- Subject: [PATCH 0/6] gnu: golang: Add minify Date: Tue, 30 Jan 2024 23:17:29 +0000

Hi Thomas and Hilton,

I've tried to resolved all highlights which Hilton pointed out and from
some investigation I've left with 3 pushed patches.

- present [3/3]
  - [X] go-github-com-tdewolff-parse-v2
  - [X] go-github-com-tdewolff-test
  - [X] go-github-com-tdewolff-minify-v2

- added to golang-xyz.scm [2/2]
  - [X] go-github-com-djherbis-atime
  - [X] go-github-com-matryer-try

And the minify looks like this with inherit and modification:

--8<---------------cut here---------------start------------->8---
(define-public minify
  (package
    (inherit go-github-com-tdewolff-minify-v2)
    (name "minify")
    (arguments
     (substitute-keyword-arguments
         (package-arguments go-github-com-tdewolff-minify-v2)
       ((#:install-source? _ #t) #f)
       ((#:import-path _ "github.com/tdewolff/minify/v2")
        "github.com/tdewolff/minify/cmd/minify")))
    (inputs
     (list go-github-com-djherbis-atime
           go-github-com-dustin-go-humanize
           go-github-com-fsnotify-fsnotify
           go-github-com-matryer-try
           go-github-com-spf13-pflag))))
--8<---------------cut here---------------end--------------->8---

Maxim or Ricardo, 

Pinging you here as following, I've built it few times locally and
everything passed just fine, for some reason CI feel bad.
https://ci.guix.gnu.org/eval/1086875

Thanks,
Oleg

signature.asc
Description: PGP signature

--- End Message ---