bug#70657: closed ([PATCH] Add go-ts-mode font-locking for function var decls)

[GNU bug Tracking System]

Your message dated Thu, 09 May 2024 00:30:14 +0000
with message-id 
<uztfs54Zi2quSYzoh7iyfpXL12W4hMJFVprKQj51UBYYa-GdhT1dcN-xCtZ_WeqgPd7Wt9xdi_hEGNFlxRqW-yU9YpMsgqTCQqPKKYrHg5Y=@rjt.dev>
and subject line Re: bug#70657: [PATCH] Add go-ts-mode font-locking for 
function var decls
has caused the debbugs.gnu.org bug report #70657,
regarding [PATCH] Add go-ts-mode font-locking for function var decls
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
70657: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=70657
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems

--- Begin Message --- Subject: [PATCH] Add go-ts-mode font-locking for function var decls Date: Mon, 29 Apr 2024 16:22:42 -0700

Tags: patch


Adds font-locking for functions in go-ts-mode declared in var specs.

Currently, all the identifiers in var specs are given
font-lock-variable-name-face font-locking.

This patch adds a rule to give identifiers in var specs
font-lock-function-name-face when they are function types.

For example, the following test is included in the patch, showing where
font-lock-function-name is applied:

var x, y, z int
//    ^ font-lock-variable-name-face
//        ^ font-lock-variable-name-face
//                ^ font-lock-type-face
var foo, bar func(x int) int
//     ^ font-lock-function-name-face
//             ^ font-lock-function-name-face
//                         ^ font-lock-variable-name-face
//                             ^ font-lock-type-face
//                                   ^ font-lock-type-face


In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version
3.24.33, cairo version 1.16.0) of 2024-04-29 built on noah-X580VD
Repository revision: 3000edc6179dfe0b5f24ae2e472826530809dfd1
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12101004
System Description: Ubuntu 22.04.4 LTS

Configured using:
 'configure --prefix=/usr/local --with-modules --with-tree-sitter
--with-threads --with-x-toolkit=gtk3 --with-xwidgets --with-gnutls
--with-json --with-mailutils --with-jpeg --with-png --with-rsvg
--with-tiff --with-xml2 --with-xpm --with-imagemagick CC=gcc-12
CXX=gcc-12'

0001-Add-go-ts-mode-font-locking-for-function-var-decls.patch
Description: Text Data

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#70657: [PATCH] Add go-ts-mode font-locking for function var decls
>
>
>
>
> Date: 
>
> Thu, 09 May 2024 00:30:14 +0000
>
>
>
>
> On Thursday, May 2nd, 2024 at 06:27, Noah Peart <noah.v.peart@gmail.com> wrote:
> > > Do we know how does other editors fontify this statement? Or maybe we can 
> > > look
> > > at how does the official documentation highlight their code?
> > 
> > From what I can tell, both neovim and vscode give them variable font-locking 
> > (basic vim doesnt
> > give them any font). The syntax highlighting is very basic in the official 
> > docs I looked at (just the repl in Tour of Go), not
> > giving variables any highlight.
> > 
> > They are variables with function values like Randy said, and looking now at 
> > other languages
> > it seems like they all give variable font-locking to named closures (eg. 
> > rust-ts-mode, lambdas in ruby-ts-mode).
> > 
> > > I'm not sure we want to do this though, since they are still variables.
> > 
> > Sounds good, thanks for taking a look.
>
> Closing.
>
>
> --- End Message ---