bug#71949: closed ([PATCH] services: web: Pass run-directory to nginx's actions.)

[GNU bug Tracking System]

Your message dated Wed, 10 Jul 2024 16:05:19 +0200
with message-id <87sewh5om8.fsf@gnu.org>
and subject line Re: [bug#71949] [PATCH] services: web: Pass run-directory to 
nginx's actions.
has caused the debbugs.gnu.org bug report #71949,
regarding [PATCH] services: web: Pass run-directory to nginx's actions.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
71949: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=71949
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] services: web: Pass run-directory to nginx's actions.
>
>
>
>
> Date: 
>
> Fri,  5 Jul 2024 17:01:20 +0200
>
>
>
>
> Reloading nginx lead to (harmless, yet annoying) alert being logged:
>
>     nginx: [alert] could not open error log file: open() 
> "/gnu/store/9l2lznlqpjcm79znq1xas378maqgysc8-nginx-1.27.0/logs/error.log" 
> failed (2: No such file or directory)
>
> Since there already is prepared runtime directory for nginx, all that was
> missing was to also pass it to the reload and reopen invocations.
>
> * gnu/services/web.scm (nginx-shepherd-service)[reload, reopen]: Pass -p flag
> with run-directory as value.
>
> Change-Id: Id5c558d65def8c1fe5cf581a4a370508ac05e550
> ---
>  gnu/services/web.scm | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/gnu/services/web.scm b/gnu/services/web.scm
> index c10bd4cdff..b73cd30fe7 100644
> --- a/gnu/services/web.scm
> +++ b/gnu/services/web.scm
> @@ -858,11 +858,11 @@ (define (nginx-shepherd-service config)
>  the same configuration file.  It is useful for situations where the same nginx
>  configuration file can point to different things after a reload, such as
>  renewed TLS certificates, or @code{include}d files.")
> -                 (procedure (nginx-action "-s" "reload")))
> +                 (procedure (nginx-action "-p" run-directory "-s" "reload")))
>                 (shepherd-action
>                  (name 'reopen)
>                  (documentation "Re-open log files.")
> -                (procedure (nginx-action "-s" "reopen"))))))))))
> +                (procedure (nginx-action "-p" run-directory "-s" 
> "reopen"))))))))))
>  
>  (define nginx-service-type
>    (service-type (name 'nginx)
> -- 
> 2.45.1
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [bug#71949] [PATCH] services: web: Pass run-directory to nginx's actions.
>
>
>
>
> Date: 
>
> Wed, 10 Jul 2024 16:05:19 +0200
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13)
>
>
>
>
> Tomas Volf <~@wolfsden.cz> skribis:
>
> > Reloading nginx lead to (harmless, yet annoying) alert being logged:
> >
> >     nginx: [alert] could not open error log file: open() 
> > "/gnu/store/9l2lznlqpjcm79znq1xas378maqgysc8-nginx-1.27.0/logs/error.log" 
> > failed (2: No such file or directory)
> >
> > Since there already is prepared runtime directory for nginx, all that was
> > missing was to also pass it to the reload and reopen invocations.
> >
> > * gnu/services/web.scm (nginx-shepherd-service)[reload, reopen]: Pass -p flag
> > with run-directory as value.
> >
> > Change-Id: Id5c558d65def8c1fe5cf581a4a370508ac05e550
>
> Applied, thanks!
>
>
> --- End Message ---