bug#74849: closed ([PATCH 0/6] Update ARM Trusted Firmware.)

[GNU bug Tracking System]

Your message dated Thu, 19 Dec 2024 16:22:37 -0800
with message-id <87ldwbursi.fsf@contorta>
and subject line Re: [bug#74849] [PATCH v2 0/6] Update ARM Trusted Firmware.
has caused the debbugs.gnu.org bug report #74849,
regarding [PATCH 0/6] Update ARM Trusted Firmware.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
74849: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=74849
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH 0/6] Update ARM Trusted Firmware.
>
>
>
>
> Date: 
>
> Fri, 13 Dec 2024 13:23:59 +0100
>
>
>
>
> Hello,
>
> I updated and moved [PATCH v2 3/8] of #70131 to this patch series.
>
> I assume the change to GCC 14 caused arm-trusted-firmware-imx8mq to
> fail.  The last patch makes it build again, with a commit (patch) from
> https://github.com/nxp-imx/imx-atf.git.
>
> I think we should verify that boards using arm-trusted-firmware-imx8mq
> would still boot, but there aren't any U-Boot packages that use it.
>
> Cheers,
> Herman
>
> Herman Rimm (6):
>   gnu: arm-trusted-firmware-rk3399: Reformat.
>   gnu: arm-trusted-firmware: Reformat.
>   import: utils: Move guix-name to (guix utils).
>   gnu: make-arm-trusted-firmware: Use guix-name.
>   gnu: make-arm-trusted-firmware: Update to 2.12.
>   gnu: arm-trusted-firmware-imx8mq: Fix build.
>
>  gnu/local.mk                                  |   2 +
>  gnu/packages/firmware.scm                     | 159 ++++++++----------
>  .../patches/8mq-enable-imx_hab_handler.patch  |  36 ++++
>  .../patches/8mq-move-stack-to-ocram_s.patch   |  88 ++++++++++
>  guix/import/elpa.scm                          |   1 +
>  guix/import/texlive.scm                       |  10 +-
>  guix/import/utils.scm                         |  10 --
>  guix/utils.scm                                |   9 +
>  8 files changed, 205 insertions(+), 110 deletions(-)
>  create mode 100644 gnu/packages/patches/8mq-enable-imx_hab_handler.patch
>  create mode 100644 gnu/packages/patches/8mq-move-stack-to-ocram_s.patch
>
>
> base-commit: 98aca7a2b6250e7f6a2ff3a93b29d0dea896ad21
> -- 
> 2.45.2
>
>
>
>
> --- End Message ---

--- Begin Message --- Subject: Re: [bug#74849] [PATCH v2 0/6] Update ARM Trusted Firmware. Date: Thu, 19 Dec 2024 16:22:37 -0800

On 2024-12-19, Vagrant Cascadian wrote:
> On 2024-12-19, Herman Rimm wrote:
>> This revision configures the ARM Trusted Firmware differently when doing
>> a native build, which should fix the 'aarch64-none-elf-gcc' errors.
>
> That does appear to work, nice!
...
>> I will give the guix-name procedure a more appropriate name in another
>> patch (series).
>
> Could the guix-name stuff just be submitted as it's own patch series?
> It seems more-or-less unrelated to this patch series, only resulting in
> a few small line changes...

I reverted the guix-name stuff and pushed as:

91f50366e5bc54951851e99f5600f9abb628b6ec (origin/master) gnu: 
arm-trusted-firmware-imx8mq: Fix build.
29ff4a6ca836c0ee8fe052eda3ad9a5d2bb8d2af gnu: make-arm-trusted-firmware: Update 
to 2.12.
c514002bd79eb49653857bddc14bd342f848cbcf gnu: arm-trusted-firmware: Reformat.
442c218c181734251ab671b29ef6bece998f6f04 gnu: arm-trusted-firmware-rk3399: 
Reformat.

I pushed, though there are somethings included that should go upstream....

These two patches do not appear to be in upstream:

    * gnu/packages/patches/8mq-enable-imx_hab_handler.patch: Add file.
    * gnu/packages/patches/8mq-move-stack-to-ocram_s.patch: Add file.

This phase should probably be reported and fixed upstream as well:

-          (delete 'configure)         ;no configure script
+          (replace 'configure          ;no configure script
+            ;; Fix ATF commit ffb7742125def3e0acca4c7e4d3215af5ce25a31
+            (lambda _
+              (unless #$(native-build?)
+                (substitute* "plat/rockchip/rk3399/drivers/m0/Makefile"
+                  (("-oc") "-oc-default"))
+                (substitute* "make_helpers/build_macros.mk"
+                  (("-oc") "-oc-default")
+                  (("-od") "-od-default")))))

I do not see any fixes in upstream about this. Works fine without this
for native building but not for cross-building.

And now I catch myself after having pushed it, I meant to switch that
back to deleting the configure phase and renaming it some other phase!
It is not really configure functionality, probably should have been with
(add-after 'unpack ... or something like that ... or just a full patch,
to make it possible to submit upstream.

Thanks for your contribution!

live well,
  vagrant

signature.asc
Description: PGP signature

--- End Message ---