|
From: | Jason Rumney |
Subject: | Re: Windows port: using Windows' default printer |
Date: | Wed, 22 Oct 2003 12:15:21 +0100 |
User-agent: | Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.5) Gecko/20031007 |
Peter 'Luna' Runestig wrote:
Hi all! Is there anything more I should do to get this patch accepted? When it comes to the issue about calling default-printer-name each time we print something, I can see several options: o Leave as is (my favorite). o Only call default-printer-name on start-up. o Make the use of the above two ways run-time configurable. o Add some caching functionality to default-printer-name, and trigger the "cache update" on WM_SETTINGCHANGE.
I favour the first option too. Worrying about a few milliseconds overhead for a system call on an operation like printing, that takes orders of magnitude longer, is not worth it IMHO. Caching would make the code overly complicated and difficult to maintain.
[Prev in Thread] | Current Thread | [Next in Thread] |