Re: The display margin

[David PONCE]

Hi Kim,

> Finally, when you use a block cursor, images are no longer shown in
> "negative" when your window cursor is a filled block cursor (only
> the border of the image is highlighted now).  So clicking on an
> image no longer makes it "unreadable"...

That's very nice!  However when using a bar cursor the image is
still shown in "negative".  Perhaps it would make sense to use an
hollow cursor in that case too.

Another possibility could be to just draw the bar in that case (a la
"Open Office").

To do the latter I applied the following patch to xterm.c:

Index: src/xterm.c
===================================================================
RCS file: /cvsroot/emacs/emacs/src/xterm.c,v
retrieving revision 1.822
diff -c -r1.822 xterm.c
*** src/xterm.c 17 Nov 2003 06:06:24 -0000      1.822
--- src/xterm.c 28 Nov 2003 12:43:35 -0000
***************
*** 7335,7340 ****
--- 7335,7341 ----
    if (cursor_glyph == NULL)
      return;
  
+ #if 0
    /* If on an image, draw like a normal cursor.  That's usually better
       visible than drawing a bar, esp. if the image is large so that
       the bar might not be in the window.  */
***************
*** 7345,7350 ****
--- 7346,7352 ----
        draw_phys_cursor_glyph (w, row, DRAW_CURSOR);
      }
    else
+ #endif
      {
        Display *dpy = FRAME_X_DISPLAY (f);
        Window window = FRAME_X_WINDOW (f);


I am not sure what solution is the best.

David