Re: supporting more faces on 256 colors xterms

[Eli Zaretskii]

> From: Dan Nicolaescu <address@hidden>
> Date: Thu, 12 Feb 2004 14:13:34 -0800
> 
> The default faces and the font-lock faces have been changed to take
> advantage of `min-colors'. These faces look very similar now on a 256
> colors xterm and on X11.

Thanks.

I see one problem with these changes: it seems like you assumed that
there are no devices supported by the current defface definitions that
can support between 8 and 256 colors.  But that is not true: the MSDOS
terminal and the Windows character terminal (you get the latter when
you start the Windows port with -nw) both support 16 colors, not 8.
The current defface definitions distinguish between the Unix 8-color
displays and the 16-color displays using several techniques:

  . Define colors for (type tty), which doesn't catch the DOS
    terminal, then let (class color) catch the DOS case.

  . Use (type pc) to catch the DOS case explicitly (this is ugly, but
    sometimes cannot be avoided).

  . Use a color definition, like "red3", that maps to appropriate
    colors on both Unix tty's and Windows/DOS 16-color terminals.

As far as I could see, your changes will modify the standard face
definitions for Windows and DOS terminals, because they treat them as
if they had only 8 colors.  It would be nice if this side effect could
be avoided.  One way to avoid this is to add face definitions for
16-color displays.

I think that adding a definition for (min-colors 16) is a Good
Thing regardless, as there's rxvt and a 16-color xterm out there.

So please consider adding face definitions for 16-color displays.